In-App Messaging CHANGELOG for M61 #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Dec 9, 2019
renkelvin
pushed a commit
that referenced
this pull request
Dec 14, 2019
commit 7b63ce904b1725e1c3ee4890a92f08637bf56d50
Author: Maksym Malyhin <mmaksym@google.com>
Date: Fri Dec 13 17:06:07 2019 -0500
FirebaseInstallations - extensions support (#4495)
* FIS - use shared user defaults if `accessGroup` is set.
* Use `FIROptions.appGroupID` to set keychain `accessGroup`
* ./scripts/style.sh
commit e78fb964b760f383095f34d13141223b91964cc1
Author: Maksym Malyhin <mmaksym@google.com>
Date: Fri Dec 13 16:38:40 2019 -0500
Scene delegate swizzling: don't crash when there is `UIScene.delegate == nil` (#4498)
commit afb2c656324421a5c71b8bd5060f237fa050f69a
Author: christibbs <43829046+christibbs@users.noreply.github.com>
Date: Fri Dec 13 16:24:21 2019 -0500
Add NS_SWIFT_NAME for FIRInAppMessagingCampaignInfo (#4294)
commit 3b585b96f4b7b4b941d0a813f44ff98fbef4a145
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Dec 12 10:02:17 2019 -0800
Flush out Zip Builder release docs (#4492)
commit 71887a455cdbb4f8aebda0adec72eb455c2eadb0
Author: Chuan Ren <renkelvin@gmail.com>
Date: Thu Dec 12 07:20:50 2019 -0800
Update FIRAuth.m (#4490)
commit bbd9cf61ddb0c61d9ef1c23d54ce82f17b380574
Author: Gil <mcg@google.com>
Date: Tue Dec 10 18:13:41 2019 -0800
Update CHANGELOG for Firestore v1.8.2 (#4485)
commit 7fd7a53c1953db3b0dcaf0e8bfdbee43eec9225e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Dec 10 14:29:15 2019 -0800
Clarify release note for external pr (#4481)
commit 9006f0ab3a61cb7ca636830dd2e5db471bb9b450
Author: Chen Liang <chliang@google.com>
Date: Tue Dec 10 13:28:42 2019 -0800
update changelog (#4479)
commit 656b9c0889da25e5698476e8831f3b434c96cbdb
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Tue Dec 10 13:07:52 2019 -0800
Remove unused test helpers (#4473)
commit f2e0a5eaedf131f0aec6fdb85cc4436dae7c0821
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Dec 10 11:30:53 2019 -0800
ZipBuilder: Remove unnecessary public's (#4456)
commit 2cc26bd1e21bacf7b61017fe438e7194f29c772b
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Dec 10 11:10:43 2019 -0800
Add -localPodspecPath option (#4453)
commit 75b881f68f4a9bb9049e67ac75e15752171b6c54
Author: Chuan Ren <renkelvin@gmail.com>
Date: Tue Dec 10 10:51:51 2019 -0800
Update CHANGELOG.md for Auth (#4465)
commit da77ba78d09952e29ebac072d19f405324b84b52
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Dec 10 08:38:52 2019 -0800
ZipBuilder: Get dependencies from the Podfile.lock (#4452)
commit a5fbc16eceb463389a9f26d3af0e2dcfc9385a84
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Dec 9 21:15:00 2019 -0800
Fix non-standard import (#4470)
commit 1297e7797ba3f2ae59f1d1ea4b45380566fc6230
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Mon Dec 9 18:38:08 2019 -0800
Add Last Limbo Free Snapshot Version to Proto (#4469)
commit 0eff50593d89dde3301709102f48cc1f5aca523b
Author: Chen Liang <chliang@google.com>
Date: Mon Dec 9 15:29:22 2019 -0800
Cleanup the documentation to clarify a few concerns developers addressed (#4468)
commit 5b7066fff18b4f212a3abc592f2e44b76318121f
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Dec 9 14:54:21 2019 -0800
Zip Builder - update protos (#4454)
commit fe67f465511d2521df4efe583b8fe39f91060126
Author: Chen Liang <chliang@google.com>
Date: Mon Dec 9 14:19:00 2019 -0800
update changelog for messaging and instanceID (#4466)
commit 485b3d88aa91334ba849ac8d5f9708b6d69dc680
Author: christibbs <43829046+christibbs@users.noreply.github.com>
Date: Mon Dec 9 16:48:40 2019 -0500
Fix crash when displaying UIAlertController for a test on device message that errored (#4446)
* Use application delegate window to show test on device error alert, run on main thread
* Refactor the display of the test on device error alert to use a window on the foregrounded scene
* More descriptive variable name for the view controller used to present the error alert
* Import UIKit at the top of FIRIAMDisplayExecutor.m
* Early return in test on device error flow if there's no foregrounded scene
* scripts/styles.sh
commit 40045b8cd4e890ee0201f247c8d152c48b483842
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Dec 9 13:42:46 2019 -0800
Consolidate SecureCoding to avoid a new subspec (#4462)
commit 3a397c27e4152fe2b729ace8d1e555ea8c2f7bf1
Author: christibbs <43829046+christibbs@users.noreply.github.com>
Date: Mon Dec 9 15:54:03 2019 -0500
In-App Messaging CHANGELOG for M61 (#4464)
commit b49ece73a7bf84b902ff4842f45577b9231b33e3
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Mon Dec 9 11:02:35 2019 -0800
Update CHANGELOG (#4463)
commit 050e8bc5d1a7e3e111b91c418657e2834a36202a
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Mon Dec 9 10:32:49 2019 -0800
Updating Database Changelog (#4460)
commit 88e58a2921ea61bc9880b8eb729caf22061cd8a8
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Dec 9 10:20:57 2019 -0800
M61 Core Changelog (#4458)
commit d1e06bce4b09e48191f11dbe58556366d070d594
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Dec 9 10:08:52 2019 -0800
GoogleUtilities Changelog update (#4459)
commit e7172d5f090531c64d1395095c86af183b2815c6
Author: Gil <mcg@google.com>
Date: Sat Dec 7 18:33:18 2019 -0800
Post-migration cleanups (#4451)
* Fix naming violations.
* Remove xcgmock
* Remove FSTTypes.h
* Remove FSTClasses.h
commit 389ec1d232ad05e1008313913797f73c3c4a4b8a
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Sat Dec 7 10:09:03 2019 -0800
Disable use-libraries pod-lib-lint tests for Core (#4457)
commit 4b2bb2d4208838e82f7834b0c01e1a471f2d5f94
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Dec 6 13:46:37 2019 -0800
Fix Zip README blank line separator (#4450)
commit 80e25a4cb84c7087b510caa9b10cae668a96f212
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Dec 6 13:46:14 2019 -0800
Speed up zip builder development iteration (#4449)
commit 5fcb29158daf353e2c3fd81fc56f199bba836fb7
Author: Maksym Malyhin <mmaksym@google.com>
Date: Fri Dec 6 15:45:52 2019 -0500
Add "swift" flag to `firebaseUserAgent` (#4448)
* Add "swift-runtime/true" to user agent when Swift detected.
* Use "swift" instead of "swift-runtime"
* ./scripts/style.sh
* Add comment with the Swift check clarification
* Fix bridging header path
* Fix SwiftObject class name for old Siwft versions.
* Add swift runtime flag with value true or false (to be able to distinguish from a no-value-provided case).
commit d6c117050eb70920841a4e44caf0eb07bdcdf08f
Author: Chuan Ren <renkelvin@gmail.com>
Date: Fri Dec 6 10:50:40 2019 -0800
Handle UISceneDelegate changes in Auth (#4380)
* Handle UISceneDelegate changes in Auth
* Fix pr issue
* Update GULAppDelegateSwizzler.m
* Fix pr issue
* Update GULLoggerCodes.h
* Update GULLoggerCodes.h
* Update GULAppDelegateSwizzler_Private.h
* Update GULAppDelegateSwizzlerTest.m
commit 0882dbc46dbda845225c96ee1e1487d16fd86ff4
Author: Ryan Wilson <wilsonryan@google.com>
Date: Fri Dec 6 13:32:48 2019 -0500
Allow multiple `configure` calls in an extension. (#4436)
* Allow multiple `configure` calls in an extension.
Some extensions have an entry point that gets called multiple times.
Instead of having to check if a default app has already been configured,
allow multiple `configure` calls if and only if it's in an extension and
the FIROptions contents are identical.
* Review comments.
* Updated comment.
commit 85365cb08919d9c33fa229e9f30562cf04bebded
Author: Gil <mcg@google.com>
Date: Fri Dec 6 10:11:05 2019 -0800
Get the remainder of Objective-C tests running under CMake (#4430)
* Add Objective-C API tests to the CMake build
* Fix signedness warnings under the CMake build
* Get the remainder of Objective-C tests running under CMake
Also:
* Add a Path::HasExtension check
* Change spec tests to pick up json without NSBundle
commit 9ea819af2ff4612bb520bed60f479d76b2e8545b
Author: christibbs <43829046+christibbs@users.noreply.github.com>
Date: Thu Dec 5 17:09:52 2019 -0500
Fix FIAM --analyze nullability issues (#4435)
* Fix card message nullability warnings with non-nil assertions
* Get rid of asserts, still pass --analyze
* Remove --no-analyze for FIAM in travis.yml
commit 7ae64d37bf969ab9d0c14959fcd0c9d5029fc918
Author: Gil <mcg@google.com>
Date: Thu Dec 5 08:58:56 2019 -0800
Update CMake build docs for Windows (#4440)
commit c2fa88e3b07be5882de5232d2bb5714af7f1ea6f
Author: Gil <mcg@google.com>
Date: Thu Dec 5 08:37:15 2019 -0800
Rewrite local store tests in C++ (#4421)
* Move FSTLocalStoreTests to core/test
* Add testutils for constructing TransformMutations
* Rewrite local store tests in C++
commit d73d9379515a27b0ad4e958a6d71094fb1549f96
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Dec 5 06:58:17 2019 -0800
Lazily register for Core's user agent (#4441)
commit f47ce4bbf335429d199d26f17a76dbadba188a1f
Author: dmandar <dmandar@users.noreply.github.com>
Date: Wed Dec 4 17:07:43 2019 -0800
Throw an error if the fetch response returns an error (irrespective o… (#4438)
* Throw an error if the fetch response returns an error (irrespective of status code).
* Remove duplicate metadata set call.
* Add comment.
commit 374f1acd4fced07a9af6460271ae5cdb555f8052
Author: Gil <mcg@google.com>
Date: Wed Dec 4 14:27:17 2019 -0800
Add ccache support to our CMakeLists.txt. (#4439)
This cuts the full rebuild-and-test time from 2m7s to 38s on Linux.
commit ec0a7c88fa494a10317e57fd786941bfba45c535
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 13:08:18 2019 -0800
Consolidate NOTICES files (#4437)
commit ed064409e46de8c6d18ddfbe252b589a667df00e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 11:25:51 2019 -0800
Simplify Firebase pod naming (#4428)
commit 75ac5c043f200d2008b20a4b78d7644a067d974b
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 11:07:31 2019 -0800
Firebase to generic pod cosmetic update (#4427)
commit f76ad19fe31a393091854fd2cdecd749e994a33e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 11:01:50 2019 -0800
Rename CocoaPod.swift to FirebasePods.swift (#4423)
commit a372f4544d871fb312a296a5f574c2b4b4fe5356
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 10:54:03 2019 -0800
ZipBuilder: -zipPods option (#4422)
commit d31bdfc7be9240e819bef9be8ad5210af59edaa2
Author: Chen Liang <chliang@google.com>
Date: Wed Dec 4 09:21:42 2019 -0800
Fix typo (#4432)
commit 20a212cbc38c21c7acaa8e388b1d36c656e4730f
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 08:51:13 2019 -0800
Zip Builder V2 Doc with Implementation summary (#4429)
commit 785c704d35271369260bd1ed2ab3873e6fb998a9
Author: dmandar <dmandar@users.noreply.github.com>
Date: Wed Dec 4 07:44:31 2019 -0800
Internal code cleanup. (#4403)
* Minor code cleanup. Rename internal method, fix logging in test app.
* Rename fetchConfigWithExpirationDuration method in tests.
* Fix style.
commit 86a49f4b27e0cc6a77ba4a7751e0c10bb0a87ec0
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Dec 4 06:58:16 2019 -0800
Make module map build deterministic (#4433)
commit bd9d9d8b3c9a288f9f4ae1b643cd8d347ca5df05
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Tue Dec 3 12:24:41 2019 -0800
Index-Free Queries (disabled, some code + tests missing) (#4418)
commit c75e98fc38abb49c76caeb70d7eaef5c82587786
Author: christibbs <43829046+christibbs@users.noreply.github.com>
Date: Tue Dec 3 14:10:05 2019 -0500
Change unit tests to avoid OCMock verifying a method call on a real object (#4420)
* Fix OCMock verifying a real object
* Delete duplicate GoogleService-Info.plist
* Don't lock OCMock version
* Validate method call on mockDisplayExecutor
commit afb8e71f85506bfe6fbd1c98d3ca4f6c420602e8
Author: Ryan Wilson <wilsonryan@google.com>
Date: Tue Dec 3 13:59:16 2019 -0500
Update GUComponents OCMock dependency. (#4426)
commit 4d353570e7c5d7aa50ad7a15ded85382be29d29b
Author: Ryan Wilson <wilsonryan@google.com>
Date: Thu Nov 28 11:51:52 2019 -0500
Fix component startup time. (#4137)
* Fix component startup time.
The `configureWithApp:` call shouldn't have been added - the
component registration system can provide proper configuration
instead of relying on a static `configureWithApp:` call. Many of
the SDKs relied on singletons being available there, which wasn't
necessary. Instead, this should happen in the component creation
block and use the instantiationTiming parameter on
registerInternalLibrary.
* Fix missing `nil` statement.
commit 6f8732dcfbe603220d0b0939da63a983329b8cb5
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Nov 28 08:46:31 2019 -0800
Support concurrent Zip Builder runs (#4409)
commit 009fcae38dd42632117b87bd9852f6da50eafb58
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 27 16:26:44 2019 -0800
Add archs option to ZipBuilder (#4405)
commit 347e503237247700e6a6cc3fd66926b5da684988
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 27 15:11:20 2019 -0800
Build Zip with modern CocoaPods (#4404)
commit c877a07d1745cf4528a1d16eeaca8d6ad3c21a8e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 27 14:23:53 2019 -0800
Add check for invalid options (#4411)
commit 306e6c062209d20d8ab73e84effed27fecbada06
Author: Ryan Wilson <wilsonryan@google.com>
Date: Wed Nov 27 12:08:47 2019 -0500
Fix OCMock issues with FIS (#4406)
Fixes #4351
commit 71b09774d3dcf11877d873b7cf9a248ef60f514d
Author: Gil <mcg@google.com>
Date: Tue Nov 26 15:43:42 2019 -0800
Fix TSAN test failures under CMake (#4396)
commit 737e3b9d8e073d5c71d5bfaa6274402827255b30
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Nov 26 12:22:14 2019 -0800
Zip Builder V2 Plan (#4341)
commit c097f9976aad1566aa0bb860107ccf702951406c
Author: Ryan Wilson <wilsonryan@google.com>
Date: Tue Nov 26 15:16:06 2019 -0500
Fix incorrect OCMock usage (#4402)
Fixes 4350
#no-changelog
commit 2ed9f9ecc59a5726098b69acc01f45dfd887eb63
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Mon Nov 25 21:36:12 2019 -0500
Fix compilation with older versions of Visual Studio (#4398)
Looks like Visual Studio 2015 has trouble with `constexpr` arrays:
```cpp
constexpr char Foo[] = "abc";
```
but not with `constexpr` pointers to `char`:
```cpp
constexpr const char* Foo = "abc";
```
commit 4eecadc8e7b9159da96a09654251bc75a303a1d1
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Mon Nov 25 16:53:28 2019 -0500
Fix Linux build with GCC 4.8.5 (#4395)
commit cb7d94a39e9494cd03f4908d9aaf18e740cb0987
Author: Gil <mcg@google.com>
Date: Mon Nov 25 12:19:34 2019 -0800
Fix definition of ExcludeFromBackups on non-Apple platforms. (#4394)
commit bc071a88d09c8da6a9f3f32e1dcf53a1f23d3290
Author: Vinay Guthal <vguthal@google.com>
Date: Mon Nov 25 11:21:32 2019 -0800
Add fis heartbeat support (#4353)
* installapiservice
* insallations api test
* update tests
* add mock tests
* add installations api
commit d8851168e2d1c83e71cc0ca980b2e91f56d5ad83
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Mon Nov 25 13:43:30 2019 -0500
Fix several small linter issues (#4390)
commit 7481e8b97f1d22b2195ca8907542329e18d5881e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Nov 22 16:57:08 2019 -0800
travis job consolidation for Core, GDT, and FIAM (#4385)
commit 76b733eb431001d6ecad0424754cf9a4ba4c47cf
Author: Gil <mcg@google.com>
Date: Fri Nov 22 16:45:22 2019 -0800
Make ExcludeFromBackups part of the filesystem API (#4388)
This completely removes platform dependencies from LevelDbPersistence,
making it easier to integrate into the blaze build in google3.
commit d9c3e6a15fa6a4e2ccb144c9cf1b11e027c425c6
Author: Gil <mcg@google.com>
Date: Fri Nov 22 16:44:57 2019 -0800
Fix the build on Windows (#4384)
* Fix errors about Abseil using std::copy
The C++11 version of this function can be unsafe if used improperly.
Defining this macro is also done in the Abseil build, though they don't
export the setting.
* Prevent output differences in generated certificate data
* Don't regenerate nanopb sources on Windows
There's something wrong with the interaction between protoc and the
nanopb generator that prevents this from working properly.
commit a803a861e43f7c88adfc1794b69670959e7bcb9d
Author: Gil <mcg@google.com>
Date: Fri Nov 22 15:03:44 2019 -0800
Extract AppDataDir from LevelDbPersistence (#4386)
commit a9455cdc197d4af289a0cd023d2f59d34713052e
Author: Ryan Wilson <wilsonryan@google.com>
Date: Fri Nov 22 13:41:47 2019 -0800
Fix Carthage CD overriding the Zip build. (#4373)
This separates the frameworks built for Carthage from the frameworks
built for the zip file.
commit 84dfb8046d5e39b32b4f0e8c76a31d6194c14166
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Fri Nov 22 16:04:49 2019 -0500
Fix fuzz build (#4369)
* Fix unused variable
* Fix the Linux build (#4383)
Reshuffling our dependencies in #4279 broke the build; apparently the
Linux linker is less forgiving than the one on macOS.
commit 4041d081e2e449e844d249d3165ba08d64400efd
Author: dmandar <dmandar@users.noreply.github.com>
Date: Thu Nov 21 15:29:03 2019 -0800
lastFetchTime's accessor does not reference the backing ivar. Silence the corresponding CLANG warning. (#4379)
commit 37c97d8f3298ad3b00004f37ed55c6d324fd2bc1
Author: Gil <mcg@google.com>
Date: Thu Nov 21 15:25:32 2019 -0800
Fix completely out-of-source CMake builds (#4377)
Visual Studio 2017 runs creates its CMake output directory in a location
outside the git checkout, which causes the check for a current git
repository to fail.
commit 842439bea9d649490f4ecd969aef4086bb63b30e
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Thu Nov 21 14:55:12 2019 -0800
Fix a public import of a private header (#4378)
commit d97ea8a3293d0d9f896d56e10bbfefff861dab80
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Thu Nov 21 13:30:13 2019 -0800
Fix race conditions (#4370)
commit 1cf8a944d78040749d96a0b82b608495b0bcc717
Author: Thomas Bouldin <inlined@users.noreply.github.com>
Date: Thu Nov 21 11:46:56 2019 -0800
Add +[FIRServerValues increment:] (#4328)
Add +[FIRServerValues increment:]
* Definition is currently in an "unreleased" extension to FIRServerValues
* Functions that resolve server values now need access to any existing snapshot; please help ensure that this is not done wastefully.
* Tests are added to FData.m
* Setting increment values
* Setting increment priorities
* Type coercion
* Overflows
* Some tests are renamed to make it clear that ServerValues != timestamps
commit a2a54ea62045639064a1f80e6bfb3b58721a7def
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Thu Nov 21 10:42:01 2019 -0800
Set the request time for backend time correction (#4371)
commit 22fe61cc1b9cb7906fbe4b14fd39f022005f73d0
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Nov 21 07:34:55 2019 -0800
Xcode 11.1 instead of 11.2 (#4375)
commit 49e48a0dfcb64d8d233539806ebb7f62f0fd3cd1
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Nov 19 21:01:44 2019 -0800
Post Firestore 1.8.1 patch merge to master (#4366)
commit fcc2aabae8eb4c3441a64834c12ed76d5cfd99db
Author: Chen Liang <chliang@google.com>
Date: Tue Nov 19 19:21:26 2019 -0800
Fix a few misuse of OCMock in Messaging and InstanceID (#4363)
commit 0d476a399bb68592856fd0b840b88ac273cfac35
Author: Gil <mcg@google.com>
Date: Tue Nov 19 13:35:32 2019 -0800
Upgrade Firestore emulator to 1.10.2 (#4358)
This fixes several flakes in the integration tests.
commit 33ec39abf7e0d9caf148f3e5b36af8340e9e3dda
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Tue Nov 19 11:35:48 2019 -0800
Update FIRCD, GDT, and GDTCCT CHANGELOGs (#4360)
* Update FIRCD CHANGELOG
* Update GDT CHANGELOG
* Update GDTCCT's CHANGELOG
* Update CHANGELOG.md
* Update CHANGELOG.md
commit bf4ebefe141f4e7e4c5063b49e23fc5ced17235f
Author: Maksym Malyhin <mmaksym@google.com>
Date: Tue Nov 19 13:45:29 2019 -0500
GoogleDataTransport minor version bump (#4359)
commit 2a8d069b770ffd316b8d61ee91557190ff910be9
Author: wu-hui <53845758+wu-hui@users.noreply.github.com>
Date: Tue Nov 19 13:40:43 2019 -0500
Run integration tests from CMake on mac (#4276)
commit a1f89955e92579a639b8d3c6ca679a86bc885145
Author: Maksym Malyhin <mmaksym@google.com>
Date: Tue Nov 19 13:05:41 2019 -0500
CoreDiagnostics and GDT patch version bump (#4357)
commit 57f8d7d675a337486a016eb2f00e7e824909a7ea
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Tue Nov 19 01:50:08 2019 -0500
Embed root certificates into the binary on Apple platforms as well (#4352)
Currently, on iOS Firestore is loading `roots.pem` file from the gRPC bundle. The mechanism has proved to be brittle, so instead we can use the same approach as the CMake build does -- parse the file at build time and embed its contents into the binary.
One downside of this approach is that now we would have to periodically update the generated files for embedding manually. Judging from history, `roots.pem` is updated quite often in gRPC repo, and can be expected to be modified on each release.
The command to regenerate the certificates is something like:
```sh
mkdir build # From the root of the repo
cd build
cmake .. && make -j 8 generate_grpc_root_certificates
```
TESTED=with Fireeats.
commit 9c803fc3566a9524bf54f7829a642b33448143de
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Nov 18 16:40:58 2019 -0800
Lock OCMock to 3.4 while investigating test failures with 3.5.0 (#4344)
commit bfcdef563d368ecbeafbaedc1fa2720f38a404f8
Author: Ryan Wilson <wilsonryan@google.com>
Date: Mon Nov 18 17:51:11 2019 -0500
Fix #4343 incorrect OCMock test. (#4346)
commit 0e2a4dfb5e0da71d7f8b5fb100b81cda401b399d
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Nov 18 13:08:56 2019 -0800
Add arm64e to the zip build (#4342)
commit 210850900e1bd9623f6ff2dca00db1828996c198
Author: Alan Andrade <alan.andradec@gmail.com>
Date: Mon Nov 18 10:48:51 2019 -0800
Keeps a strong reference for handling dynamic deeplinks (#4325)
commit 75b8f92564458773e294445e4ab25ecc67215efc
Author: Chuan Ren <renkelvin@gmail.com>
Date: Mon Nov 18 10:04:18 2019 -0800
Fix rawNonce in encoder (#4337)
commit 825398a4d2e419eba01fecc965eaa91f1c84a213
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Nov 15 16:01:56 2019 -0800
Fix test bug (#4330)
commit 20c9f899df0ce50276df85e1da0f5f84335c45e8
Author: Vinay Guthal <vguthal@google.com>
Date: Fri Nov 15 17:42:29 2019 -0500
add heartbeat support for iid (#4323)
* add heartbeat support for iid
* format code
* fix tests
* fix formatting
commit b88bee8e0d3daa10cb9ec4ba3cfd2ce6616a47c1
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Fri Nov 15 13:57:14 2019 -0800
Use uncompressed proto data if gzip fails or is larger (#4324)
* Use uncompressed proto data if gzip fails or it larger
* Add comment referencing gzip's magic number
commit e6a49053366d90f1d47392a4f4e04e5a3b6c1117
Author: Gil <mcg@google.com>
Date: Fri Nov 15 09:34:44 2019 -0800
Add concurrent execution support to Executor (#4309)
commit efbf9bdf1db282e4996e090b0ad86145256911e6
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Fri Nov 15 01:30:19 2019 -0800
Send diagnostic data to the FLL backend instead of the CCT backend (#4196)
* Send diagnostic data to the FLL backend instead of the CCT backend
* Handle FLL redirects and set the User-Agent
The podspec now surfaces the SDK version.
* Add unit tests for handling redirects
commit 3261d120a9762f81d209e1584b8d05d2b38616ef
Author: Ryan Wilson <wilsonryan@google.com>
Date: Thu Nov 14 19:50:23 2019 -0500
Update versions for Release 6.13.0 (#4318)
commit 0a973c1207a691fca1b7f863e4100f7713a933e8
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Nov 14 16:49:41 2019 -0800
Fix FirebasePod test (#4320)
commit 5b4f184ddba8552ecd21edeb3788086b6c25cc8e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Nov 14 14:46:51 2019 -0800
Fix CI regression in FIAM from Google Utilities changes (#4319)
commit be17ade45835ed93418093a5e564fb8f6c999eb1
Author: Vinay Guthal <vguthal@google.com>
Date: Thu Nov 14 15:22:20 2019 -0500
add heartbeat feature for ios sdks (#4098)
* add heartbeat feature
* fix client logtype
* make class functions
* add subspec changes
* remove test file
* add heartbeat tests
* use FileDataStorage instead of Storage
* add style
* use file data storage instead of storage
* fix test location
* add tests
* address comments
* update storage heartbeat with the new api
* update format
* update formatting and use correct enums
* rename
* update storage
* fix heartbeat
* update heartbeat tests
* fix styling
* Revert change
* heartbeat storage
* add comments
* update storage
* address comments
* add comments
* address comments
* fix style
* add style
* add style
* move heartbeat date storage
* move to environment
* update tests
* add tests
* small change
* add google utilities
* delete the header file
* update tests
* remove headers
* fix comment
* gul heartbeat date storage
* Update versions for heartbeat PR (#4311)
* update podfile
* Fix Firestore build under CMake
GoogleUtilities must now build SecureCoding
commit cc6fcfcc8dc64d197393faf3e4eef78fa50d98aa
Author: Morgan Chen <morganchen12@gmail.com>
Date: Wed Nov 13 15:47:11 2019 -0800
Update Auth changelog (#4306)
commit bd5c72f9c7adb49c90602604714517c44de836c3
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 13 14:45:05 2019 -0800
Core M60 release notes (#4307)
commit 1abc77c163511b1c41d7256da13055fc883028f1
Author: Gil <mcg@google.com>
Date: Wed Nov 13 11:51:52 2019 -0800
Fix pretty printing tests on Windows. (#4290)
commit d0c73b04e4babe7f97b5f085d174ab7cf6298783
Author: Chen Liang <chliang@google.com>
Date: Wed Nov 13 11:20:35 2019 -0800
update changelog for M60 (#4289)
commit c6614f06efb57a1aa78d07b026e695c8e7f61661
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Wed Nov 13 09:24:20 2019 -0800
Update Storage Changelog for 3.4.2 (#4304)
commit ce197964cbb55f483817c150fc7956ca34c3c4d9
Author: Thomas Bouldin <inlined@users.noreply.github.com>
Date: Tue Nov 12 16:18:50 2019 -0800
Add cocoapods-generate to dev instructions (#4286)
commit e018203001f34080786af6fd1c2eb475acde57e6
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Tue Nov 12 16:07:07 2019 -0800
Update CHANGELOG (#4298)
commit 36ff74bb36bc8f46e5e7f336c7a05fe02aaa7bb4
Author: dmandar <dmandar@users.noreply.github.com>
Date: Tue Nov 12 14:38:40 2019 -0800
Update comment. (#4297)
commit d1b3466f8dd0d0ef1c1a23dce79b4d72748d6b78
Author: Gil <mcg@google.com>
Date: Tue Nov 12 14:29:57 2019 -0800
Update CHANGELOG for Firestore v1.8.0 (#4296)
commit f0157ae7c5957622e8a04b2455e8d9298370ed56
Author: Gil <mcg@google.com>
Date: Tue Nov 12 14:21:39 2019 -0800
Port FSTLRUGarbageCollectorTests to C++ (#4283)
commit 0f6a08a94d25f0e10482317a64245f684482423d
Author: dmandar <dmandar@users.noreply.github.com>
Date: Tue Nov 12 14:19:20 2019 -0800
Update RC ReleaseNotes for M60. (#4293)
commit 017095754467dcba2cc6adaf6d52d8dba1abc49d
Author: Brian Chen <chenbrian@google.com>
Date: Tue Nov 12 13:07:58 2019 -0800
Allow querying for arrays in IN queries (#4285)
commit e6565d0ad43e09837439e59412f463b835d55e89
Author: Chuan Ren <renkelvin@gmail.com>
Date: Tue Nov 12 11:10:56 2019 -0800
Revert "Revert "Add OIDC nonce support (#4183)" (#4220)" (#4288)
This reverts commit 11a3417d1c3e406ca6255eb6fc18aae5149a6ba8.
commit f529da0ef4acb630c8143c8bf062cce999803b40
Author: Vinay Guthal <vguthal@google.com>
Date: Tue Nov 12 12:21:08 2019 -0500
Add function to gul secure encoding to encode multiple calsses (#4282)
* style
* secure coding
commit d0565392004a10abd2f5fdf317819cdb380165d7
Author: Gil <mcg@google.com>
Date: Mon Nov 11 12:15:46 2019 -0800
Migrate FSTLevelDBMigrationsTests to C++ (#4272)
commit a3197cc8cd4de870185d82ddb5eccb6e032b693e
Author: Maksym Malyhin <mmaksym@google.com>
Date: Mon Nov 11 14:15:09 2019 -0500
FIRStorage.callbackQueue fixes (#4281)
commit a63dab446396fdc842b8b8d09779f5c8f40884ff
Author: Gil <mcg@google.com>
Date: Fri Nov 8 15:11:26 2019 -0800
Get tests passing on Linux (#4275)
* Fix build on Linux
* Fix pretty-printing test on Linux
commit 69d39f660e57a3b437d1a478a4714cc40196869c
Author: Gil <mcg@google.com>
Date: Fri Nov 8 14:48:32 2019 -0800
Port FSTLevelDBTransactionTests to C++ (#4270)
* Move FSTLevelDBTransactionTests to C++
* Update CMake project
* Update Xcode project
* Rewrite FSTLevelDBTransactionTests in C++
commit 2eb92a02db98b1e0c1a940a8fe6751f89be37d77
Author: Gil <mcg@google.com>
Date: Fri Nov 8 14:40:02 2019 -0800
Remove workarounds for nanopb ODR violations (#4273)
Now that we depend upon gRPC 1.24+ (and it no longer includes nanopb) we
no longer need any build order workarounds.
Fixes b/111328563.
commit 2cc8f23706b205a90d97f2ef1fb9018786d68a48
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Fri Nov 8 17:35:28 2019 -0500
Add a changelog entry on `Protobuf` removal. (#4266)
* Add a changelog entry on `Protobuf` removal.
Removed in #4189.
commit 3b9fd3ddf921e772d7b5e8851ff966e9cd335cce
Author: dmandar <dmandar@users.noreply.github.com>
Date: Fri Nov 8 11:14:57 2019 -0800
Do not activate if fetch returns NO_CHANGE (#4260)
* Do not activate if a new fetch call has not resulted in any data change.
* Add tests.
* Fix style.
* Persist lastETagUpdateTime in the database.
commit db8cb2321a3f508b5094e5e5c7f80940dbc631af
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Thu Nov 7 21:43:53 2019 -0500
C++ migration: cleanup leftover bits of Objective-C (#4190)
* remove `OBJC_CLASS` (it's no longer used);
* make most sources `.cc` instead of `.mm` (all exceptions are Apple platform-specific code).
commit 62ef244cdefac0a2ffcacaa083a0f90bdb328d31
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Thu Nov 7 20:39:53 2019 -0500
C++ migration: remove the dependency on Objective-C `Protobuf` library (#4189)
commit d0686d2f631c75fafe8763f88398edf2b6ad99d4
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Thu Nov 7 19:37:28 2019 -0500
C++ migration: implement pretty-printing of Nanopb-generated messages (#4184)
Note: the output is indistinguishable from what is generated by the Objective-C library, with two exceptions:
* class names are different (due to using prefixes, e.g., `GCFS`);
* order in which map fields are outputted can be different (which I presume is to be expected).
I verified this by running integration tests and using simple diffing code to compare outputs: in the destructor of each `Message<T>` (if it's not moved-from), serialize the `Message` to bytes, create an Objective-C proto out of those bytes, convert both protos to their string form, compare the strings (ignoring minor differences in indentation, etc.). Out of 5.7K comparisons, there were just two cases of differences:
* one was in `SerializerTest.FailOnInvalidInputBytes`; since the input in question is invalid, this doesn't seem to require much attention;
* another one was due to differing floating point precision: C++ produces `1.79769e+308` while Objective-C produces `1.79769313486232e+308`. Added a TODO.
Example output:
```
2019-10-28 21:44:56.941749-0400 Firestore_Example_iOS[78883:2094242] 6.11.0 - [Firebase/Firestore][I-FST000001] WriteStream (7f903ca53d50) write request: <WriteRequest 0x70000991ef08>: {
writes {
update {
name: "projects/varconst-11-a51fd/databases/(default)/documents/test-collection/u6QizHeYjqt8Xe61kBoi"
fields {
key: "key"
value {
string_value: "value"
}
}
}
}
stream_token: "\031\020hB\002\201\364\265\265"
}
```
commit 12fb9f61d287f8edff9c37dffe4f518f90919449
Author: Gil <mcg@google.com>
Date: Thu Nov 7 15:23:14 2019 -0800
Upgrade gRPC to 1.24.3; upgrade protobuf to 3.9.2 (#4252)
* Upgrade gRPC to 1.24.3
* Upgrade C++ Protobuf to 3.9.2
Disable -Wunreachable-code in protobuf-generated code
* Regenerate C++ protos with protobuf 3.9.2
* Generate objc protos with Protobuf 3.9.2
commit 3c6721c0fe889bc5eb04a2ecb0d8f4b95d6bc874
Author: Gil <mcg@google.com>
Date: Thu Nov 7 12:02:10 2019 -0800
Get Windows and Linux builds to compile again (#4256)
* Rename IN to IN_ for compatibility with Windows
windows.h defines IN and INOUT macros that indicate the directionality
of parameters in the Windows API.
* Rename DeleteFile to DeleteSingleFile
This avoids a conflict with the Win32 macro, which expands to either
DeleteFileA or DeleteFileW, based on the Unicode mode of the build.
* Avoid using declarations of non-types outside classes
VS2017 doesn't accept these even though clang does.
* Avoid relying on default construction of type traits
This is a C++14 extension that VS2017 does not expose in C++11 mode.
* Add missing dependencies
* Define LevelDbPersistence::AppDataDirectory on Windows.
* Make Container a top-level type
This avoids a GCC error:
error: typedef ‘using value_type = int’ locally defined but not used [-Werror=unused-local-typedefs]
Removing value_type isn't actually possible because it is actually used,
but indirectly via template.
commit 6317c627108b7633641cced8b059ff008f1febfd
Author: Gil <mcg@google.com>
Date: Thu Nov 7 12:01:15 2019 -0800
Upgrade GoogleTest to 1.10.0 (#4250)
commit f6e1eea53c6ce2f1fa92012c38390b9130a0f71d
Author: Maksym Malyhin <mmaksym@google.com>
Date: Thu Nov 7 13:26:52 2019 -0500
FIS: IID incompatible version exception. (#4258)
* FIS: IID incompatible version exception.
* FirebaseInstallations.podspec: set preprocessor flags based on env vars.
* FIS Travis: set required env vars
* /scripts/style.sh
* FIS: FIRInstantiationTimingEagerInDefaultApp
* FIS: FIRInstantiationTimingAlwaysEager
commit 54b1458ebbfc510319640e46ceba8e34cf7d3608
Author: Chen Liang <chliang@google.com>
Date: Wed Nov 6 20:11:15 2019 -0800
Remove unnecessary rmq database operations in unit tests. (#4236)
commit 79f45ee5c57b3b3ca9f11f5eb83a47d470826e44
Author: Gil <mcg@google.com>
Date: Wed Nov 6 19:59:10 2019 -0800
Make the CMake build warning free (#4251)
* Silence "file has no symbols" warnings from ranlib
* Silence warnings in Abseil's time zone library
commit 540f76d38eef4763b5687126b5abb79899d3954f
Author: Gil <mcg@google.com>
Date: Wed Nov 6 19:55:13 2019 -0800
Port FSTMutationQueueTests to C++ (#4208)
commit f89f624aed0bfa44a3fdab91ea0b9c5fbb64b48f
Author: Gil <mcg@google.com>
Date: Wed Nov 6 19:43:01 2019 -0800
Require CMake 3.5.1; upgrade Google Benchmark to 1.5.0 (#4249)
* Require CMake 3.5.1
This is the version required by the latest versions of gRPC and Google
Benchmark. See discussion https://github.com/google/benchmark/pull/613.
Remove version check around find_package(XCTest)
Also, add a dependency on objc protos that was missing but somehow
implicitly being added before.
* Upgrade Google Benchmark to 1.5.0
commit 1c34a8de4c4159a6f93ec7581f7d72c90dffe518
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 6 17:17:45 2019 -0800
Clarify an ambiguous instruction (#4259)
commit 369bf41ca414f106b1bf0bc42db09dda13b85427
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Nov 6 14:18:52 2019 -0800
Test with Xcode 10.3 instead of 10.2 (#4254)
commit d18d515739770df646b133253741ecf7a0202508
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Nov 6 14:56:42 2019 -0500
Merging the 6.12.0 release into master (#4223)
* Update versions for Release 6.12.0
* Update versions for Release 6.12.0 - Firestore
* Update versions for Release 6.12.0
* Update CHANGELOG for Firestore v1.7.0 (#4195)
* FirebaseCore version bump to 6.3.3 (#4213)
* Release manifst updated. (#4219)
* Revert "Add OIDC nonce support (#4183)" (#4220) (#4222)
This reverts commit ffe4a3a5b4840b2fca6fd76357ede711b3dbfd0f.
* Revert Auth podspec version bump. (#4232)
* Release manifest - Auth removed (#4233)
* 6.12.0: Firebase.podspec FirebaseAuth pod version reverted, cherry-pick #4231 (#4234)
* Firebase.podspec - revert Auth
* check_whitespaces.sh: ignore notices. (#4231)
* Remove unnecessary NOTICES file (#4242)
commit 6db5ac46e00d151374a5583f5e700d6de6ae2560
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Nov 6 10:21:43 2019 -0500
ZipBuilder README update (#4248)
commit 52505143e39af132c3ff95967a21cb110a9e89c8
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Nov 5 17:42:04 2019 -0800
Add --analyze to pod lib lint tests (#4161)
commit 0695f75b7cfbf126f2d7e91d58df9e605b71ccb5
Author: Morgan Chen <morganchen12@gmail.com>
Date: Tue Nov 5 16:37:11 2019 -0800
Update Core CHANGELOG for M59 (#4244)
* Update Core CHANGELOG for M59
* Fix typo
* Specify Xcode point version
* Fix trailing whitespace
commit da88c98ad84d0f39902e09919506102ebb5e756e
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Nov 5 16:16:47 2019 -0800
Allow failures in FirebaseMessaging (#4245)
commit 9a611a859da446234f7ec59e403a7956821fa8c6
Author: Morgan Chen <morganchen12@gmail.com>
Date: Tue Nov 5 13:01:45 2019 -0800
Update header docs based on feedback in cr/278458897 (#4235)
* Update header docs based on feedback in cr/278458897
* Change param names in .mm to match header file
commit e9d492f52c8bd98ca23b10f9128848ed955fa7ea
Author: dmandar <dmandar@users.noreply.github.com>
Date: Tue Nov 5 11:24:22 2019 -0800
RemoteConfig M59 release notes (#4243)
* Add RC changelog for M59
* Remove duplicate.
commit 1953cc59a483560ddb923bfcaffb07428809e733
Author: Gil <mcg@google.com>
Date: Tue Nov 5 09:12:34 2019 -0800
Integrate with Abseil via CocoaPods (#4097)
Use Abseil 0.20190808
commit f1b10df362ab3a56f7784267eacab41d8b25ee3a
Author: Gil <mcg@google.com>
Date: Tue Nov 5 09:10:01 2019 -0800
Don't use the address of a TimeSlot as a key for removal (#4212)
After a TimeSlot executes, it deletes itself and removes itself from
ExecutorLibdispatch's schedule_. The DelayedOperation still refered to
this now freed address. If another TimeSlot is scheduled and operator
new happens to allocate a TimeSlot that reuses the address, and the
DelayedOperation is subsequently canceled, this will cancel the new task
before it has run.
This change fixes this by using a dedicated counter for TimeSlots that
effectively isn't reused. Note that while it is possible for the counter
to wrap around, this would take tens of years of continuous execution to
happen and require cancelation of TimeSlot created tens of years ago to
create the possibility of collision which is a sufficiently impractical
problem as to be ignorable.
commit 38d9643a00f87df3462c8fd86f16645edeade794
Author: Gil <mcg@google.com>
Date: Mon Nov 4 17:03:10 2019 -0600
Disallow empty document fields (#4229)
Port of firebase/firebase-android-sdk#643.
Also make error messages align with Android's.
commit 0d64c5bf690380b2bca809949f7a6b682b9b5fd4
Author: Gil <mcg@google.com>
Date: Mon Nov 4 15:51:51 2019 -0600
Prevent race conditions in DatastoreTest (#4227)
* Prevent race conditions in DatastoreTest
Previously it was possible for tasks on the async queue to outlive the
instance of the DatastoreTest which could crash or cause TSAN
violations.
This fixes a flake that appeared in the AuthOutlivesDatastore test case.
* Improve readability of the error classification tests
commit af019d09fce0744f3a316d7bc650f27149773a22
Author: Maksym Malyhin <mmaksym@google.com>
Date: Mon Nov 4 16:21:46 2019 -0500
check_whitespaces.sh: ignore notices. (#4231)
commit 2f53582530e977679522b20a0550459c6e704fe4
Author: wu-hui <53845758+wu-hui@users.noreply.github.com>
Date: Mon Nov 4 14:39:44 2019 -0500
Various minor fixes to make SDK compile on Linux (#4185)
commit 76b47085c907935da3ab7f97bcedc9453a8ba31a
Author: Maksym Malyhin <mmaksym@google.com>
Date: Mon Nov 4 11:45:17 2019 -0500
FIS: Use IID auth token to authorize IID migration. (#4224)
* `FIRInstallationsIIDTokenStore` introduced. `FIRInstallationsIIDCheckinStore` removed.
* FIRInstallationsIIDTokenStoreTests
* Run ./scripts/style.sh
* FIRInstallationsIIDTokenStore implementation.
* ./scripts/style.sh
* Fix tvOS and macOS availability.
* Rename IIDAuthToken -> IIDDefaultToken
* FIRInstallationsIIDTokenStoreTests: fix flaky IID token removal
* ./scripts/style.sh
commit 3ea7197090fcee23b35865c5d1e4e588b4c370fd
Author: Gil <mcg@google.com>
Date: Sat Nov 2 09:09:25 2019 -0500
Port FSTQueryCacheTests to C++ (#4160)
* Move FSTQueryCacheTests files to Firestore/core
* Rewrite QueryCache tests in C++
* Fix test flake in local store tests
This doesn't affect production because we always set the additional
references pointer there, but it's technically optional and some tests
don't do this.
commit 11a3417d1c3e406ca6255eb6fc18aae5149a6ba8
Author: Chuan Ren <renkelvin@gmail.com>
Date: Fri Nov 1 13:14:07 2019 -0700
Revert "Add OIDC nonce support (#4183)" (#4220)
This reverts commit ffe4a3a5b4840b2fca6fd76357ede711b3dbfd0f.
commit b5b836670aa459b62be3ecdddf8f87e52dca9d08
Author: Morgan Chen <morganchen12@gmail.com>
Date: Thu Oct 31 17:47:57 2019 -0700
Fix formatting breakage (#4214)
commit f0bc70433aebeaa73f69fe480267de1dd086118c
Author: Morgan Chen <morganchen12@gmail.com>
Date: Thu Oct 31 16:56:06 2019 -0700
Add kokoro CI skeleton to firebase-ios-sdk (#4201)
* Add kokoro files
* Fix missing pod install in kokoro
* Add missing gem
* add export LC_CTYPE=en_US.UTF-8
* Add no-op for metrics collection
* Fix missing newline at end of file
* Add kokoro readme
* Add job structure section to README
* Add correct folder structure and better docs
commit 8c0ab30279d5aa347571b8a04375b9979c96633b
Author: Michael Haney <mikehaney24@users.noreply.github.com>
Date: Thu Oct 31 11:25:37 2019 -0700
Address issues found by repeated tsan runs (#4202)
commit a507b40f1719e77c339580427257f7a81b56bb7b
Author: ChaoqunCHEN <chaoqunc@google.com>
Date: Thu Oct 31 08:50:07 2019 -0700
Add bundle id http header to FIS requests (#4194)
* Add bundle id http header to FIS requests
* Add bundle id http header to FIS requests
commit 05b7a8ec6ffb50eab83134024b0d1d9a2c1880d9
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Wed Oct 30 12:37:22 2019 -0700
Update Database CHANGELOG.md (#4197)
commit 04177614d0b11f9c260d4dff76523fbf0659964b
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Wed Oct 30 14:30:52 2019 -0400
Fix fuzz build (#4192)
commit c93b71d57a14963f9a3ba5fd2d97549541ed0d2b
Author: Gil <mcg@google.com>
Date: Wed Oct 30 08:44:08 2019 -0700
Update CHANGELOG for Firestore v1.7.0 (#4195)
commit b310be4f326ca7cbc1112114d8e1c76d106c25f6
Author: Chen Liang <chliang@google.com>
Date: Tue Oct 29 18:49:20 2019 -0700
update changelog for messaging and instanceID in M59 (#4181)
commit 8a4b210f6f039efd80f45c73b0eccc3084b72d5a
Author: Chen Liang <chliang@google.com>
Date: Tue Oct 29 18:49:01 2019 -0700
fix warning (#4186)
commit 8ea6b0dbb4f6432ea139b80b82cf02d1f5fcd19e
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Tue Oct 29 20:14:35 2019 -0400
Add a changelog entry on the C++ serializer migration (#4188)
commit 251a70f26a9c7ff806b396d4df0a5c43e503fa7a
Author: Brian Chen <chenbrian@google.com>
Date: Tue Oct 29 14:13:02 2019 -0700
Make IN queries publicly available (#4174)
commit ffe4a3a5b4840b2fca6fd76357ede711b3dbfd0f
Author: Chuan Ren <renkelvin@gmail.com>
Date: Tue Oct 29 13:03:37 2019 -0700
Add OIDC nonce support (#4183)
commit 2cac1f520e8887a3395d6ae995f7f8facd37dc22
Author: Ryan Wilson <wilsonryan@google.com>
Date: Tue Oct 29 09:17:15 2019 -0400
Only assign errors if parameter is non-NULL. (#4168)
* Only assign errors if parameter is non-NULL.
This fixes #4164.
* Remove unnecessary commenting.
* Remove other unnecessary comment.
commit 441d7eda8b1e1a03c4a88a2b281be206d8ab6baf
Author: Brian Chen <chenbrian@google.com>
Date: Mon Oct 28 22:22:37 2019 -0700
Change id to NSArray<id> for IN queries (#4182)
commit fb441a0376b0343d35ff36c18ee246f40f5be2b3
Author: Gil <mcg@google.com>
Date: Mon Oct 28 13:03:21 2019 -0700
Build all sources with CMake (#4159)
* Fix field initialization order
* Reduce dependencies in objc_compatibility_apple_test
This makes it possible to build and test util without having to build
everything
* Add a lint check for CMake files
* Find XCTest, if available
* Fix CMakeLists.txt to include all sources
* Fix test flake in local store tests
This doesn't affect production because we always set the additional
references pointer there, but it's technically optional and some tests
don't do this.
commit 67de92800500cfbc21df633dc0faf472141719a9
Author: Chen Liang <chliang@google.com>
Date: Mon Oct 28 12:45:47 2019 -0700
move database operation off main thread (#4053)
commit 1930f0e2227a748a436d37740bba8d1e797d484e
Author: Ryan Wilson <wilsonryan@google.com>
Date: Mon Oct 28 14:19:51 2019 -0400
Change import of XCTestCase to XCTest (#4171)
commit e4ac5b9e8900fd29b8996a03903c5716432bfd8e
Author: Ryan Wilson <wilsonryan@google.com>
Date: Mon Oct 28 09:56:36 2019 -0400
Fix documentation comments for the Container. (#4178)
commit 4d10f32641668291f68ebebfdc72e72941e795c5
Author: Chen Liang <chliang@google.com>
Date: Fri Oct 25 15:37:37 2019 -0700
update keychain access level (#4172)
commit 48a2a9e0fe21b0e7c7c8e5faa6c4e59e2a93ebfa
Author: Maksym Malyhin <mmaksym@google.com>
Date: Fri Oct 25 17:14:02 2019 -0400
Keychain: use `kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly` instead of deprecated since iOS 13 `kSecAttrAccessibleAlwaysThisDeviceOnly`. (#4169)
commit 563854e81ef335e84e489e340d9a3a09a05c1063
Author: Ryan Wilson <wilsonryan@google.com>
Date: Fri Oct 25 14:05:29 2019 -0400
Copy component container to GoogleUtilitiesComponents (#4113)
* Move component container to GoogleUtilities.
This will allow non-Firebase SDKs to take advantage of the component
system. Note: Firebase Core will eventually move over to use this, but
more investigation is needed about how this can be done with the least
amount of churn for other SDKs.
* Fix dependency on Logger.
* Add CHANGELOG entry.
* Fix selector name.
* Move ComponentContainer subspec to new pod.
* Rename to GoogleUtilitiesComponents.
* Style, make public headers.
* Update travis with new name.
* Add project to if_changed.sh
* Review comments.
* Enabled static framework, changed homepage.
* Fix missing quote.
commit 42118c9b1398af076b9a05557b4cb8bb21ddc70a
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Oct 24 06:36:55 2019 -0700
Stop using statics in header (#4149)
commit 8b23a3266d96859fad3d7d3fa83bc2aeeab192b0
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Wed Oct 23 20:56:44 2019 -0400
Remove Objective-C serializers and make local/ and remote/ (almost) fully C++ (#4151)
There are more sources that can be `.cc` now (e.g., in API); these are left for a follow-up PR.
The dependency on Objective-C proto library cannot be removed just yet due to current lack of pretty-printing support for Nanopb.
commit a34540f9cb9a1b476b6bfbadcb0f8eb13557fc45
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Oct 23 20:32:23 2019 -0400
FIS: race condition (#4148)
* FIRInstallationsSingleOperationPromiseCache: a failing test for race condition added.
* ./scripts/style.sh
* FIRInstallationsSingleOperationPromiseCache: synchronize entire code blocks not relying on `atomic` property. The atomic property synchronization was insufficient to synchronize `newOperationHandler()`.
* ./scripts/style.sh
commit 6fd815a5ed0e9b1301ad27b241e1dfbcac0b60b7
Author: Gil <mcg@google.com>
Date: Wed Oct 23 12:28:16 2019 -0700
Port FSTRemoteDocumentCacheTests to C++ (#4136)
commit af6f4e512ba61ebbc1d0a9ed0370ea6fe6896159
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Oct 23 14:22:28 2019 -0400
FIS: Make sure refreshed auth token is stored to the storage. (#4146)
* FIRInstallationsIDControllerTests: test refreshed token is stored.
* FIRInstallationsIDControllerTests: all required tests updated to expect refreshed token to be stored.
* Tests: assert all FBLWaitForPromisesWithTimeout
* FIRInstallationsIDController: saving refreshed token implemented.
* FIRInstallationsIDController: duplicated code removed.
commit 341312b15d7d989a5c8ed6b1f1c8c845b3de7186
Author: Gil <mcg@google.com>
Date: Wed Oct 23 10:58:50 2019 -0700
style.sh generated changes (#4140)
* style.sh generated changes
* Fix style.sh detection of swift formatting issues
commit 532162d55daed3c4974b2eb84576ad9e3362c599
Author: Morgan Chen <morganchen12@gmail.com>
Date: Wed Oct 23 09:49:18 2019 -0700
Update changelogs for M58 (#4135)
* Update changelogs for M58
* Remove link from Firestore changelog
commit 2c53bb9139656408ad0ea6b4c78baab21f9bd3e9
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Tue Oct 22 21:52:55 2019 -0400
C++ migration: use C++ serializer for communicating with the local store (#4116)
After this PR is merged, the Objective-C serializers can be completely removed from the project. Also, this PR changes the `Message` class quite a bit; it's probably in its final form now.
I did some performance testing locally and came to the conclusion that replacing Objective-C serializers with their C++ versions brings no performance downgrade; actually, there seems to be a very slight improvement. I tested writing large batches and reading large collections:
* both are network-dominated; wall time is about twice longer than CPU time;
* serialization represents a pretty small percentage of the total CPU time;
* for writing, C++ serialization is a little more efficient, taking ~6% of total CPU time, compared to ~8% in the Objective-C version. I've seen similar results for reading.
All integration tests pass, under Address Sanitizer as well.
commit 47afee7e8dcbfa7e2c55d1203246da367b43ee1c
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Oct 22 14:49:51 2019 -0700
Update README for Firebase pod for mac/tv (#4139)
commit a621e592178e6a4290d9bc0268e1a948c3dd589d
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Tue Oct 22 11:35:29 2019 -0700
Merge 6.11.0 (#4134)
commit 3f1fbe7e9a25b9c85e6df71c53f0f5ea09c8c989
Author: Gil <mcg@google.com>
Date: Mon Oct 21 20:12:46 2019 -0700
Migrate FSTPersistenceTestHelpers to C++ (#4122)
* Move FSTPersistenceHelpers to core/test/.../local
* Rewrite persistence_testing in C++
* Migrate from FSTPersistenceTestHelpers to C++ persistence_testing
* Rename .mm to .cc where possible in IndexManager tests
* Remove Objective-C gunk from index_manager_test.h
commit 2bcfcc2cfba6c360a9542f6d5b88133b657142d8
Author: wu-hui <53845758+wu-hui@users.noreply.github.com>
Date: Mon Oct 21 22:30:25 2019 -0400
remove NSException from firestore client (#4131)
commit e241a9a9b8eb47f9ebaef97e4505410ebb1f1d53
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Mon Oct 21 16:43:45 2019 -0400
Optimize `DocumentKey` comparisons (#4123)
This came up while I was investigating the effect of new C++ serializers on performance. When writing large batches, one of the hottest functions turned out to be `firebase::firestore::util::operator==(const DocumentKey& lhs, const DocumentKey& rhs)`, accounting for 15-20% of total CPU time. There are two reasons why comparing keys is currently not very efficient:
* `BasePath::CompareTo`, to which this comparison eventually resolves, mistakenly uses the general-purpose `util::Compare` function rather than the more efficient `util::CompareContainer`;
* the default implementation of `Comparable::operator==` results in two comparisons per element ("less-than" followed by "greater-than"), even though one would be sufficient.
Fixing these issues results in 8-10% CPU time improvement when writing large batches.
To work around the latter, this PR defines a new mixin `InequalityComparable` that is exactly the same as `Comparable`, except it doesn't define `operator==`, forcing the inheriting class to implement it manually.
Some measurements (all done on the emulator in release mode with no logging) follow; the test case was to write 10 batches of 500 very small documents. Note that I found wall clock to fluctuate too much to be reliable and instead use the measurements from XCode's Time Profiler, which (presumably) shows CPU time. Each measurement shows total CPU time spent on `firebase::firestore::util::operator==` (all instantiations, not just for `DocumentKey`), followed by the percentage of time spent in this function compared to total runtime:
* no optimization:
* 275ms/18.8%;
* 245ms/16.9%;
* 252ms/18.5%.
* `CompareContainer` optimization:
* 124ms/9.7%;
* 110ms/8.5%;
* 128ms/10.0%.
* `CompareContainer` + `ComparableWithEqual` optimizations:
* 95ms/7.3%;
* 100ms/8.0%;
* 112ms/9.2%.
commit 2a45cf659888011458a44e72fd8d8338c32bff06
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Oct 21 10:41:52 2019 -0700
Update Travis to Xcode 11.2 (#4129)
commit c5271e36a99d33af7da782e52b06965e52c8186b
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Mon Oct 21 09:00:43 2019 -0700
Switch to Xcode 10.2 since travis 10.1 config is broken (#4128)
commit 63f77849622dc047a371773d0c4d7b02b775e86b
Author: Maksym Malyhin <mmaksym@google.com>
Date: Mon Oct 21 10:46:54 2019 -0400
Travis: install particular version of clang-format and swiftformat. (#4127)
commit 65ec051abdac283868dd381c3a404dec47115b26
Author: Maksym Malyhin <mmaksym@google.com>
Date: Mon Oct 21 09:37:57 2019 -0400
FIS: Complex unrecoverable error handling reverted and replaced by a simple log message. (#4120)
* Revert "FIS: stored registration error timeout (#4032)"
This reverts commit 37747dbb3d22e1b07165a6064cb1de9f63018656.
* Revert "FirebaseInstallations: CreateInstallation API request error handling (#4024)"
This reverts commit 27384c0a2c67ef06a7d77ef7d7daf692066a5d25.
* Complex unrecoverable error handling reverted and replaced by a simple log message.
commit 0f2a0bfeef3263f3b4c51854ec22b267dd2ecd38
Author: Konstantin Varlamov <var-const@users.noreply.github.com>
Date: Fri Oct 18 17:58:14 2019 -0400
Use C++ serializer for communicating with the backend (#4013)
Replace all uses of `FSTSerializerBeta` in `remote_objc_bridge.{h,mm}` with the C++ `Serializer`. Also, make most of `remote/` sources pure C++ and remove no-longer-used methods in `FSTSerializerBeta`. All integration tests pass, under Address Sanitizer as well.
Unfortunately, pretty-printing is still delegated to Objective-C, so that `remote_objc_bridge.mm` still has to be an Objective-C++ source (and which prevents inlining `remote_objc_bridge` into the streams).
#no-changelog Will add a changelog entry when local serializer is ported, too.
commit 5a7e177666e48185a20a6dde853e929b93e465b0
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Oct 18 14:32:31 2019 -0700
Add travis_retry to mitigate impact of GDTCCT flakes (#4119)
commit 8c1168d1886f2355046b9015c2f5046609b019e9
Author: Maksym Malyhin <mmaksym@google.com>
Date: Fri Oct 18 16:21:38 2019 -0400
FirebaseInstallation: send IID checkin data on IID migration. (#4114)
* FIRInstallationsIIDCheckinStore with tests introduced.
* FIRInstallationsIIDCheckinStore implementation and tests.
* Store IID checkin data.
* FIRInstallationsIDControllerTests: IID checkin migration tests.
* FIRInstallationsIDController: IID checkin migration logic.
* style.sh
* FIRInstallationsAPIServiceTests: IID migration header test.
* FIRInstallationsAPIService: send IID checkin data in CreateInstallation API request.
* FIRInstallationsIIDCheckinStoreTests: fix FIRInstanceIDCheckinStore subDirectoryName.
* FIRInstallationsIIDCheckinStoreTests: fix missing sub directory.
* Disable FIRInstallationsIntegrationTests for macOS.
* FIRInstallationsIntegrationTests: properly disable all tests on macOS.
* Fix.
commit cd460eca2d96a249e919d7e07db269ba4cba4bc2
Author: Gil <mcg@google.com>
Date: Fri Oct 18 12:58:45 2019 -0700
Rationalize input validation exceptions and assertion failures (#4107)
* Rationalize input validation exceptions and assertions
... under a single ThrowHandler concept. This makes it possible to set
an alternative ThrowHandler in our C# bindings that properly translates
input validation exceptions to the correct .NET exception types.
* Rename api/input_validation.h to util/exception.h
* Reimplement util/hard_assert.h in terms of util/exception.h
commit 7e781660642f6f2dfabf8ce7af28242bdb29d079
Author: Gil <mcg@google.com>
Date: Fri Oct 18 12:56:46 2019 -0700
Use base_configuration_reference.real_path rather than path (#4118)
real_path has the correct value after a pod deintegrate, while path has
some nearly correct value. No idea why these are different.
commit f932b260ea030dee718c1c2ba9762a45a1aa16af
Author: Morgan Chen <morganchen12@gmail.com>
Date: Fri Oct 18 12:45:47 2019 -0700
[danger] Don't check changelogs on non-source changes (#4115)
* Only check changelogs on PRs that modify objc/objc++ source
* Fix trailing whitespace
* Fix style and add swift files to changelog check
* Fix trailing whitespace
commit d8751b58553bec866b60b97067ef4f08eed502c5
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Oct 18 11:17:31 2019 -0700
Update README.md for Firebase pod updater (#4067)
commit ac333d1822e5108ab10fe2a0d2f338affaf7d4b7
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Fri Oct 18 11:03:21 2019 -0700
Use the ZipBuilder as a template to make a Firebase Pod updater (#4064)
commit 0a04968d3dd4f426210807c9d68b9c89f10e8bc4
Author: Morten Bek Ditlevsen <morten@ka-ching.dk>
Date: Fri Oct 18 19:56:10 2019 +0200
Workaround for NSDecimalNumber longLongValue issue. (#4109)
commit 2ebb82d1c511551748ebac4149e0dcdd090491af
Author: wu-hui <53845758+wu-hui@users.noreply.github.com>
Date: Thu Oct 17 17:04:47 2019 -0400
LocalSerializer feature complete (#4046)
* LocalSerializer feature complete
* Addressing comments 1
* Walk around nanopb boolean issue
* Rename to SafeReadBoolean
commit 3942be5f027213413e2bec4e65de10d1d3dc6fba
Author: Morgan Chen <morganchen12@gmail.com>
Date: Thu Oct 17 12:32:12 2019 -0700
Fix danger erroring on PRs from forks (#4103)
Also fixes an issue in Danger's path matching.
commit 2a434e07061e150d0f602a48342f2cdf93f216a4
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Thu Oct 17 10:06:07 2019 -0700
Move all ReferenceDelegate memory handling to .cc file (#4101)
This removes the requirement to include reference_delegate.h in consuming tests
commit b1be1a9c70d5726f27e341c9cc1b3cf982bb3cae
Author: Gil <mcg@google.com>
Date: Thu Oct 17 10:03:01 2019 -0700
Ensure that projectIDs are validated (#4073)
* Avoid priming the backend for emulator tests
* Validate that nil project ids are rejected
commit d8e3a11bb1a804123bfd6b147ec0b8216b75feee
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Oct 17 09:45:04 2019 -0700
Restore Firebase pod to closed source location (#4112)
commit 7794f0e5394c4e0069e64188950a4bb85cd4db0b
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Thu Oct 17 06:43:08 2019 -0700
CocoaPods 1.8.4 (#4090)
commit e62d05b4f1bfbc49448e6ea3f081dea3d76f6471
Author: Chuan Ren <renkelvin@gmail.com>
Date: Wed Oct 16 17:04:33 2019 -0700
Remove !@available notation (#4105)
commit e0b6d2347cce18ad3f64b0b4e29c0bf743e6af59
Author: Chen Liang <chliang@google.com>
Date: Wed Oct 16 16:09:03 2019 -0700
tokenWithAuthorizedEntity: method should also check if token is fresh (#4096)
commit 0f315d65dc908f5c3eab37459fca24fb91bf2813
Author: Sebastian Schmidt <mrschmidt@google.com>
Date: Wed Oct 16 15:13:05 2019 -0700
Fix potential race during client initialization (#4091)
commit 7be3039d4e056058cfb10f92201e63c4dd7e5687
Author: Chuan Ren <renkelvin@gmail.com>
Date: Wed Oct 16 14:33:56 2019 -0700
Built for xcode 10 (#4095)
commit 16a955731840dcb57e93a543db1fe1b928fd5649
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Oct 16 14:32:25 2019 -0700
Add Xcode 10 testing back (#4094)
commit 539ff07fd1d64324c797b5cf848bc283fe702870
Author: Gil <mcg@google.com>
Date: Wed Oct 16 11:41:50 2019 -0700
Avoid references to DocumentIDProtocol in Swift < 5.1 (#4092)
commit eded656b99506e7e6f96c1690a85e420a96bdf60
Author: Morgan Chen <morganchen12@gmail.com>
Date: Wed Oct 16 11:40:23 2019 -0700
Add danger checks (#4070)
commit 795a72bfa3b7aba39dfc438eb6fc5f422f447174
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Oct 16 12:12:31 2019 -0400
Remote Config test app: use local IID version. (#4088)
commit dc4adf855eb4b943b29fb26c688e8ca790342067
Author: Maksym Malyhin <mmaksym@google.com>
Date: Wed Oct 16 10:27:20 2019 -0400
FIS: travis - split jobs by platform speed up builds. (#4081)
commit 3b133a64561ad1ba84387e983c6f6a46ebf029c8
Author: Paul Beusterien <paulbeusterien@google.com>
Date: Wed Oct 16 06:22:19 2019 -0700
Disable Xcode 8.3 tests (#4086)
commit e6f073afd802c2dcf3604cb80a35fdd1d0cf9c3a
Author: Gil <mcg@google.com>
Date: Tue Oct 15 21:06:14 2019 -0700
Update CHANGELOG for Firestore v1.6.1 (#4078)
commit c7c58101e0467ec849e65186c9ff96f0cb1f89c2
Author: Chuan Ren <renkelvin@gmail.com>
Date: Tue Oct 15 17:57:57 2019 -0700
Revert "Add OIDC nonce support (#4071)" (#4082)
This reverts commit e88b52fb676d86df0bf665f27a899bfed46efc9c.
commit e954421c85d3bcecd7486fbeb343b47c3a8b9822
Author: Chen Liang <chliang@google.com>
Date: Tue Oct 15 17:03:08 2019 -0700
Update changelog for messaging and instanceID (#4077)
commit 2a43d214f1af8cbc720a37c6c19e34a7bb87c544
Author: Maksym Malyhin <mmaksym@google.com>
Date: Tue Oct 15 17:37:07 2019 -0400
FirebaseInstallations: re-generate Installation on HTTP 401 and 404 (#4079)
* WIP: FID re-generating introduced.
* WIP: FID regenerating tests.
* FIS regenerate: tests and fixes.
* Cleanup.
commit 5a39cf10710cf3c7d1f7e2f09be98b72b2f09834
Author: Chuan Ren <renkelvin@gmail.com>
Date: Tue Oct 15 13:19:09 2019 -0700
Use UIApplication.con…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to get #4446 in before the freeze.