From 1494c4b800886e6c2732aff05d95a4e472290c0d Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Thu, 14 Mar 2024 13:41:23 -0400 Subject: [PATCH] Enable previously failing `(Firestore) Node.js and Browser (Chrome) Tests` (#8067) A Firestore CI test configuration was previously disabled in our GitHub action Workflows due to a 100% failure rate. While revisiting this issue months later, it seems that the test now passes. This might be related to our Node v20 CI upgrade. As a bonus, fixed a comment typo in the check changeset script. --- .github/workflows/test-all.yml | 3 --- scripts/ci/check_changeset.ts | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index fce2b722814..1a5cc20a2ef 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -161,9 +161,6 @@ jobs: name: (Firestore) Node.js and Browser (Chrome) Tests needs: build runs-on: ubuntu-latest - if: false - # Disable test for now since it's failing 100% of the time since - # https://github.com/firebase/firebase-js-sdk/pull/7453 and it needs to be investigated. steps: # install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo - name: install Chrome stable diff --git a/scripts/ci/check_changeset.ts b/scripts/ci/check_changeset.ts index da6d62f0c1b..234eef87cd1 100644 --- a/scripts/ci/check_changeset.ts +++ b/scripts/ci/check_changeset.ts @@ -46,7 +46,7 @@ const bumpRank: Record = { /** * Get highest bump that isn't the main firebase package, return -// numerical rank, bump text, package name. + * numerical rank, bump text, package name. */ function getHighestBump(changesetPackages: Record) { const firebasePkgJson = require(resolve(