From 2be43eadf756e45da7ad3ae7ba104ac5f0e557fa Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 29 Sep 2020 16:54:10 -0700 Subject: [PATCH] Fix compile error + add Changelog for #3819 (#3864) --- .changeset/neat-crews-rule.md | 5 +++++ packages/firestore/lite/src/api/transaction.ts | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/neat-crews-rule.md diff --git a/.changeset/neat-crews-rule.md b/.changeset/neat-crews-rule.md new file mode 100644 index 00000000000..2b140b68814 --- /dev/null +++ b/.changeset/neat-crews-rule.md @@ -0,0 +1,5 @@ +--- +"@firebase/firestore": patch +--- + +Internal changes to support upcoming modular API. diff --git a/packages/firestore/lite/src/api/transaction.ts b/packages/firestore/lite/src/api/transaction.ts index d29cde7d498..bd84a9ece3a 100644 --- a/packages/firestore/lite/src/api/transaction.ts +++ b/packages/firestore/lite/src/api/transaction.ts @@ -123,9 +123,14 @@ export class Transaction { * * @param documentRef A reference to the document to be set. * @param data An object of the fields and values for the document. + * @param options An object to configure the set behavior. * @return This `Transaction` instance. Used for chaining method calls. */ - set(documentRef: DocumentReference, data: Partial): this; + set( + documentRef: DocumentReference, + data: Partial, + options: SetOptions + ): this; set( documentRef: DocumentReference, value: T,