Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rxfire build fix #1085

Merged
merged 2 commits into from Aug 2, 2018
Merged

Rxfire build fix #1085

merged 2 commits into from Aug 2, 2018

Conversation

davideast
Copy link
Member

Added rxjs and firebase as dev dependencies.

hiranya911
hiranya911 approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix.

@hiranya911 hiranya911 merged commit fd41378 into master Aug 2, 2018
@davideast davideast deleted the rxfire-fix branch August 2, 2018 22:38
hiranya911 added a commit that referenced this pull request Aug 3, 2018
@hiranya911
Revert "Rxfire build fix (#1085)"
afbf200 
This reverts commit fd41378.
hiranya911 added a commit that referenced this pull request Aug 3, 2018
@hiranya911
Revert "Prep rxfire release" (#1086)
d4251ae 
* Revert "Rxfire build fix (#1085)"

This reverts commit fd41378.

* Revert "Enable strict function types (#1082)"

This reverts commit 22ed571.

* Revert "Fixes servicerworker/client state syncing (#1074)"

This reverts commit 2dab48d.

* Revert "Prep rxfire release (#1079)"

This reverts commit c74c3b9.
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davideast @hiranya911 @google-oss-bot