Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if crypto.getRandomValues is available #3487

Merged
merged 3 commits into from Aug 17, 2020

Conversation

neelance
Copy link
Contributor

@neelance neelance commented Jul 27, 2020

On some IE11 the randomBytes helper crashes with "TypeError: getRandomValues is not defined". The reason is not clear, maybe something pollutes self.crypto with a bad polyfill. Nevertheless it makes sense to fall back to Math.random if crypto.getRandomValues is not available.

On some IE11 the randomBytes helper crashes with "TypeError: getRandomValues is not defined". The reason is not clear, maybe something pollutes self.crypto with a bad polyfill. Nevertheless it makes sense to fall back to Math.random if crypto.getRandomValues is not available.
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2020

🦋 Changeset is good to go

Latest commit: 81d4de5

We got this.

This PR includes changesets to release 9 packages
Name Type
@firebase/firestore Patch
firebase Patch
firebase-firestore-integration-test Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googlebot
Copy link

googlebot commented Jul 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@neelance
Copy link
Contributor Author

neelance commented Jul 27, 2020

@googlebot I signed it!

@googlebot
Copy link

googlebot commented Jul 27, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@neelance
Copy link
Contributor Author

neelance commented Aug 15, 2020

@schmidt-sebastian Mind taking a look? :)

neelance and others added 2 commits Aug 15, 2020
Co-authored-by: Sebastian Schmidt <mrschmidt@google.com>
@schmidt-sebastian schmidt-sebastian merged commit b97c7e7 into firebase:master Aug 17, 2020
3 checks passed
@google-oss-bot google-oss-bot mentioned this pull request Aug 18, 2020
@firebase firebase locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants