New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent __proto__ pollution in util.deepExtend #4001
Conversation
|
| Name | Type |
|---|---|
| @firebase/util | Patch |
| @firebase/analytics | Patch |
| @firebase/app | Patch |
| @firebase/component | Patch |
| @firebase/database | Patch |
| firebase | Patch |
| @firebase/firestore | Patch |
| @firebase/installations | Patch |
| @firebase/messaging | Patch |
| @firebase/performance | Patch |
| @firebase/remote-config | Patch |
| @firebase/rules-unit-testing | Patch |
| @firebase/storage | Patch |
| @firebase/functions | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Binary Size ReportAffected SDKs
Test Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits but LGTM.
| (target as { [key: string]: unknown })[prop] = deepExtend( | ||
| (target as { [key: string]: unknown })[prop], | ||
| (source as { [key: string]: unknown })[prop] | ||
| (target as Record<string, unknown>)[prop] = deepExtend( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a little cleaner if you create a type alias for Record<string, unknown> to reduce the repetitive cast.
No description provided.