Remove SimpleQueryEngine #4117
Remove SimpleQueryEngine #4117
Conversation
|
Size Analysis ReportAffected ProductsNo changes between base commit (c76e1ff) and head commit (059facc). Test Logs
|
|
Note: The diff here is kinda bad, but I renamed index_free_query_engine.ts to query_engine.ts and edited some comments. The diff is clearer in IntelliJ/Git directly. |
| * - Limit queries where a document edit may cause the document to sort below | ||
| * another document that is in the local cache. | ||
| * | ||
| * - Queries that have never been CURRENT or free of Limbo documents. |
There was a problem hiding this comment.
ultranit: I think that the "L" in "Limbo" can be lowercase, since "limbo" is not a proper noun.
There was a problem hiding this comment.
Fixed. I do consider "Limbo" more of a concept, rather than just the state that it refers to. Fixed either way though.
| @@ -67,25 +66,27 @@ const MISSING_LAST_LIMBO_FREE_SNAPSHOT = SnapshotVersion.min(); | |||
| * `getDocumentsMatchingQuery()` to detect index-free execution. | |||
| */ | |||
| class TestLocalDocumentsView extends LocalDocumentsView { | |||
| expectIndexFreeExecution: boolean | undefined; | |||
| exceptFullCollectionScan: boolean | undefined; | |||
There was a problem hiding this comment.
Typo: "exceptFullCollectionScan" should be "expectFullCollectionScan".
This PR addresses a long outstanding TODO and removes
SimpleQueryEngine, which existed to make IndexFreeQueryEngine optional during development. This PR makes IndexFreeQueryEngine the only QueryEngine.