Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTF-8 Encoding to OrderedCode #5817

Merged
merged 8 commits into from Jan 4, 2022
Merged

Add UTF-8 Encoding to OrderedCode #5817

merged 8 commits into from Jan 4, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Dec 15, 2021

This ports the string encoding from https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/main/java/com/google/firebase/firestore/index/OrderedCodeWriter.java

The tests strings are taken from the backend, while the test output is computed from Android.

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Dec 15, 2021

⚠️ No Changeset found

Latest commit: 8b615ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 15, 2021

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 16, 2021

Size Analysis Report 1

This report is too large (1361656 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Nmpub9CgoH.html

@schmidt-sebastian schmidt-sebastian changed the title Mrschmidt/utf8 Add UTF-8 Encoding to OrderedCode Dec 16, 2021
@schmidt-sebastian schmidt-sebastian marked this pull request as ready for review Dec 16, 2021
@schmidt-sebastian schmidt-sebastian requested a review from ehsannas Dec 16, 2021
Base automatically changed from mrschmidt/numbersonly to master Jan 4, 2022
@schmidt-sebastian schmidt-sebastian merged commit 4f3662b into master Jan 4, 2022
17 of 18 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/utf8 branch Jan 4, 2022
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants