Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish OrderedCode #5821

Merged
merged 11 commits into from Jan 4, 2022
Merged

Finish OrderedCode #5821

merged 11 commits into from Jan 4, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Dec 16, 2021

This finishes OrderedCode by adding byte encoding and encoding for Inifnity.

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Dec 16, 2021

⚠️ No Changeset found

Latest commit: 6f2141a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/byte branch 2 times, most recently from 02a1741 to a14ffc8 Compare Dec 16, 2021
@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 16, 2021

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (4f3662b)Merge (ce44141)Diff
    browser227 kB228 kB+145 B (+0.1%)
    esm5284 kB285 kB+182 B (+0.1%)
    main426 kB426 kB+177 B (+0.0%)
    module227 kB228 kB+145 B (+0.1%)
    react-native228 kB228 kB+145 B (+0.1%)
  • @firebase/firestore-lite

    TypeBase (4f3662b)Merge (ce44141)Diff
    browser72.5 kB72.6 kB+145 B (+0.2%)
    esm585.7 kB85.9 kB+182 B (+0.2%)
    main125 kB125 kB+177 B (+0.1%)
    module72.5 kB72.6 kB+145 B (+0.2%)
    react-native72.7 kB72.8 kB+145 B (+0.2%)
  • bundle

    12 size changes

    TypeBase (4f3662b)Merge (ce44141)Diff
    firestore (Persistence)229 kB229 kB+145 B (+0.1%)
    firestore (Query Cursors)189 kB189 kB+145 B (+0.1%)
    firestore (Query)190 kB190 kB+145 B (+0.1%)
    firestore (Read data once)178 kB178 kB+145 B (+0.1%)
    firestore (Realtime updates)180 kB181 kB+145 B (+0.1%)
    firestore (Transaction)163 kB163 kB+145 B (+0.1%)
    firestore (Write data)162 kB162 kB+145 B (+0.1%)
    firestore-lite (Query Cursors)56.3 kB56.4 kB+145 B (+0.3%)
    firestore-lite (Query)59.4 kB59.5 kB+145 B (+0.2%)
    firestore-lite (Read data once)43.8 kB44.0 kB+145 B (+0.3%)
    firestore-lite (Transaction)61.2 kB61.4 kB+145 B (+0.2%)
    firestore-lite (Write data)46.8 kB46.9 kB+145 B (+0.3%)

  • firebase

    TypeBase (4f3662b)Merge (ce44141)Diff
    firebase-compat.js753 kB753 kB+145 B (+0.0%)
    firebase-firestore-compat.js280 kB281 kB+145 B (+0.1%)
    firebase-firestore-lite.js249 kB249 kB+307 B (+0.1%)
    firebase-firestore.js770 kB770 kB+307 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XkX3OnX5vC.html

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 16, 2021

Size Analysis Report 1

This report is too large (105260 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NiwQOynDiN.html

Base automatically changed from mrschmidt/utf8 to master Jan 4, 2022
@schmidt-sebastian schmidt-sebastian merged commit be7ccb8 into master Jan 4, 2022
17 of 18 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/byte branch Jan 4, 2022
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants