Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FirestoreError to extend FirebaseError #5831

Merged
merged 10 commits into from Jan 4, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Dec 21, 2021

This changes FirestoreError to extend FirebaseError and updates the "Prune DTS" script to not remove this change again.

As part of this, I added a new test to "Prune DTS" and added a test runner for IntelliJ/WebStorm.

Fixes #5754

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Dec 21, 2021

🦋 Changeset detected

Latest commit: 30a30b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/firestore Patch
@firebase/storage Patch
@firebase/util Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/storage-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 21, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (9ca74ee) Head (c3a19cc) Diff
    esm5 284 kB 284 kB +3 B (+0.0%)
    main 426 kB 426 kB -6 B (-0.0%)
    react-native 228 kB 228 kB +1 B (+0.0%)
  • @firebase/firestore-lite

    Type Base (9ca74ee) Head (c3a19cc) Diff
    browser 72.4 kB 72.4 kB +10 B (+0.0%)
    esm5 85.7 kB 85.7 kB +3 B (+0.0%)
    main 125 kB 125 kB -8 B (-0.0%)
    module 72.4 kB 72.4 kB +10 B (+0.0%)
  • bundle

    Click to show 12 binary size changes.
    Type Base (9ca74ee) Head (c3a19cc) Diff
    firestore (Persistence) 229 kB 229 kB -28 B (-0.0%)
    firestore (Query Cursors) 189 kB 189 kB -28 B (-0.0%)
    firestore (Query) 190 kB 190 kB -28 B (-0.0%)
    firestore (Read data once) 178 kB 178 kB -28 B (-0.0%)
    firestore (Realtime updates) 180 kB 180 kB -28 B (-0.0%)
    firestore (Transaction) 163 kB 163 kB -28 B (-0.0%)
    firestore (Write data) 162 kB 162 kB -28 B (-0.0%)
    firestore-lite (Query Cursors) 56.3 kB 56.3 kB -28 B (-0.0%)
    firestore-lite (Query) 59.4 kB 59.3 kB -28 B (-0.0%)
    firestore-lite (Read data once) 43.9 kB 43.8 kB -28 B (-0.1%)
    firestore-lite (Transaction) 61.2 kB 61.2 kB -28 B (-0.0%)
    firestore-lite (Write data) 46.8 kB 46.8 kB -28 B (-0.1%)
  • firebase

    Click to show 14 binary size changes.
    Type Base (9ca74ee) Head (c3a19cc) Diff
    firebase-analytics.js 107 kB 107 kB +151 B (+0.1%)
    firebase-app-check.js 89.8 kB 89.9 kB +151 B (+0.2%)
    firebase-app.js 51.3 kB 51.4 kB +151 B (+0.3%)
    firebase-auth.js 411 kB 411 kB +151 B (+0.0%)
    firebase-compat.js 753 kB 753 kB -27 B (-0.0%)
    firebase-firestore-compat.js 280 kB 280 kB +520 B (+0.2%)
    firebase-firestore-lite.js 245 kB 249 kB +3.66 kB (+1.5%)
    firebase-firestore.js 766 kB 770 kB +3.56 kB (+0.5%)
    firebase-functions.js 30.9 kB 31.1 kB +151 B (+0.5%)
    firebase-messaging-sw.js 102 kB 102 kB +151 B (+0.1%)
    firebase-messaging.js 101 kB 101 kB +151 B (+0.2%)
    firebase-performance.js 119 kB 119 kB +151 B (+0.1%)
    firebase-remote-config.js 108 kB 109 kB +151 B (+0.1%)
    firebase-storage.js 145 kB 146 kB +772 B (+0.5%)

Test Logs

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Dec 21, 2021

Size Analysis Report

Affected Products

Diffs between base commit (9ca74ee) and head commit (c3a19cc) are too large (283,373 characters) to display.

Please check below links to see details from the original test log.

@google-oss-bot google-oss-bot added the doc-changes label Dec 21, 2021
@@ -15,6 +14,9 @@ import { FirebaseError } from '@firebase/util';
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { FirebaseError } from '@firebase/util';
Copy link
Contributor

@hsubox76 hsubox76 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the placement of this affect the build?

Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just cleaned it up.

@schmidt-sebastian schmidt-sebastian merged commit 3b481f5 into master Jan 4, 2022
21 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/firebaseerror branch Jan 4, 2022
@google-oss-bot google-oss-bot mentioned this pull request Jan 5, 2022
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants