Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Protos from JSON #5883

Merged
merged 3 commits into from Jan 13, 2022
Merged

Load Protos from JSON #5883

merged 3 commits into from Jan 13, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 12, 2022

This changes the Firestore SDK to load protos from JSON, which gets bundled directly into the source file. This should fix a bunch of problems with JS environments that use Node sources + Bundlers.

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Jan 12, 2022

🦋 Changeset detected

Latest commit: bb878ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian
Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian commented Jan 12, 2022

Verified this via a Node sample app

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Jan 12, 2022

@google-oss-bot
Copy link
Contributor

@google-oss-bot google-oss-bot commented Jan 12, 2022

@schmidt-sebastian schmidt-sebastian merged commit ff2f7d4 into master Jan 13, 2022
19 checks passed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/json branch Jan 13, 2022
@google-oss-bot google-oss-bot mentioned this pull request Jan 13, 2022
@firebase firebase locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants