Skip to content

test-all.yml: make a smaller build.tar.gz #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

test-all.yml: make a smaller build.tar.gz #7559

wants to merge 15 commits into from

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 15, 2023

No description provided.

@dconeybe dconeybe self-assigned this Aug 15, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 15, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (4decdf6) and merge commit (3935d8f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ci2yyHCVMh.html

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5880dde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 15, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (4decdf6) and merge commit (3935d8f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ghFV5WwYwr.html

dconeybe added 13 commits August 15, 2023 16:35
@dconeybe
show full output from mocha and karma in CI
738c5d5
@dconeybe
Revert "show full output from mocha and karma in CI"
3b26baa 
This reverts commit 738c5d5.
@dconeybe
test-all.yml: include node_modules/chromedriver/lib in build.tar.gz
a8a5512
@dconeybe
Merge remote-tracking branch 'origin/master' into SmallerBuildTarGz
59c11a2
@dconeybe
add back FIREBASE_CI_TEST_START_TIME
ef7944f
@dconeybe
Merge remote-tracking branch 'origin/master' into SmallerBuildTarGz
465b3fe
@dconeybe
test-all.yml: tar up ./node_modules/chromedriver instead of ./node_mo…
3d372ce 
…dules/chromedriver/lib
@dconeybe
test-all.yml: just include all of node_modules, since cherry-picking …
9dd31ec 
…specific parts doesn't seem to work.
@dconeybe
Merge remote-tracking branch 'origin/master' into SmallerBuildTarGz
89020c8
@dconeybe
test-all.yml: strip node_modules, see what happens
68a3f4e
@dconeybe
try downloading chromedriver directly
aa12dd3
@dconeybe
try not installing chrome and just using the preinstalled chrome for …
7bc482f 
…the build job
@dconeybe
specify path to executable as CHROMEDRIVER_FILEPATH instead of the pa…
5880dde 
…th to the zip file that contains it
@dconeybe
Copy link
Contributor Author

dconeybe commented Aug 17, 2023

This was an interesting adventure, but dropping it for now.

@dconeybe dconeybe closed this Aug 17, 2023
@dconeybe dconeybe deleted the dconeybe/SmallerBuildTarGz branch August 17, 2023 18:36
@firebase firebase locked and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dconeybe @google-oss-bot