From 1b2ce3afa3d4567cdaf80719b5dc6915eccc8746 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kuczmaja?= Date: Tue, 5 Mar 2024 13:11:56 +0100 Subject: [PATCH 1/3] Analytics: Fix update consent method --- packages/analytics/src/helpers.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/analytics/src/helpers.ts b/packages/analytics/src/helpers.ts index 7f9582900c2..04edfeaf5ab 100644 --- a/packages/analytics/src/helpers.ts +++ b/packages/analytics/src/helpers.ts @@ -304,7 +304,8 @@ function wrapGtag( gtagParams as GtagConfigOrEventParams ); } else if (command === GtagCommand.CONSENT) { - const [gtagParams] = args; + // If CONSENT, second arg must be 'default' or 'update' + const [gtagMethod, gtagParams] = args; gtagCore(GtagCommand.CONSENT, 'update', gtagParams as ConsentSettings); } else if (command === GtagCommand.GET) { const [measurementId, fieldName, callback] = args; From 1393c8dea586f584a594563f5b0fe5842090ba0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kuczmaja?= Date: Mon, 25 Mar 2024 10:29:18 +0100 Subject: [PATCH 2/3] remove comment --- packages/analytics/src/helpers.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/analytics/src/helpers.ts b/packages/analytics/src/helpers.ts index 04edfeaf5ab..6738f58fa75 100644 --- a/packages/analytics/src/helpers.ts +++ b/packages/analytics/src/helpers.ts @@ -304,7 +304,6 @@ function wrapGtag( gtagParams as GtagConfigOrEventParams ); } else if (command === GtagCommand.CONSENT) { - // If CONSENT, second arg must be 'default' or 'update' const [gtagMethod, gtagParams] = args; gtagCore(GtagCommand.CONSENT, 'update', gtagParams as ConsentSettings); } else if (command === GtagCommand.GET) { From cf3a06b6bb830dbfaa11a8a2ea7d3dfc9690befa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kuczmaja?= Date: Mon, 25 Mar 2024 11:20:30 +0100 Subject: [PATCH 3/3] changeset --- .changeset/fluffy-cherries-fetch.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fluffy-cherries-fetch.md diff --git a/.changeset/fluffy-cherries-fetch.md b/.changeset/fluffy-cherries-fetch.md new file mode 100644 index 00000000000..2912c6f7bbd --- /dev/null +++ b/.changeset/fluffy-cherries-fetch.md @@ -0,0 +1,5 @@ +--- +'@firebase/analytics': patch +--- + +Fix for update consents method. User consents were not being updated correctly.