Update CI node.js versions to 20.x#8055
Merged
DellaBitta merged 22 commits intomasterfrom Mar 8, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 453d4f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Contributor
Changeset File Check
|
renkelvin
approved these changes
Mar 7, 2024
Contributor
There was a problem hiding this comment.
I think our changeset checker fails on finding no changeset file, which it shouldn't. But this PR doesn't need a changeset because it only affects tests and workflows.
hsubox76
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Upgrade our CI scripts and workflows to work in Node 20.x.
nodetreatlocalhostdifferently depending on the executing OS. For instance,localhostmight resolve to the IPv6 address::1, but that's not the address that the emulators bind to.packages/rules-unit-testing/functions/package.jsonenginesdirective to define>=16instead of requiring16explicitly.Testing
CI
on: push:triggers.getTestTasksfunction inscripts/ci-test/tasks.tsto always return the full lists of tests to run. This ensured that all tests were being executed by thetest-changedworkflows.API Changes
N/A.