Add Installations Auth Id token to FirebaseServerApp #8623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da58c9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Size Analysis Report 1This report is too large (186,037 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
jamesdaniels
reviewed
Nov 4, 2024
hsubox76
reviewed
Nov 18, 2024
Contributor
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
LG so far but looks like it's still in draft status so I won't do a final review.
Contributor
Changeset File Check ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Add
installationsAuthTokenas a potential parameter when initializingFirebaseServerAppinstances. The token will be used by Installations in lieu of hitting local storage whengetIDandgetTokenare invoked.Note, this PR includes a change that throws an error if Remote Config's
fetchis invoked outside of a browser. Without this error, the PR would unlock Remote Config'sfetchinvocations in server environments, which previously failed due to Installations requiring IndexedDB at initalization. Use of Remote Config'sfetchin server enviornments is against the intent of use -- Remote Config is designed to cache and reusefetchresults by storing the results locally in IndexedDB. Unlocking server-side use of Remote Config'sfetchwould cause a significant increase of traffic on the service.Do not merge this change. It will unlock product SDKs to use Installations in server environments, but we should wait for any forward facing product SDK features to be scheduled before releasing this change to the public API surface.
Testing
Added a node test target to the Installations SDK, and wrote tests to invoke
getTokenandgetIdwithFirebaseServerAppinstances.API Changes
This conforms with the existing API proposal for
FirebaseServerAppwhich included an Installations Auth token.