Removed unnecessary types #9372
Open
+27
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c087753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
reviewed
Nov 11, 2025
Contributor
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
- changeset
- yarn format
@hideconstructorwill keep it out of the types, which is good enough here, but if you're planning to publish reference docs (I see that PR hasn't been merged yet) I don't know if it will work. I don't think it's a tag api-documenter recognizes. You might have to put both@hideconstructorand@internal.- I'm getting a lot of errors on build (duplicates of this one in a few different places), are you getting these? It doesn't prevent the build from completing but it's probably not good.
src/index.ts → dist/index.esm.js...
(!) Plugin rpt2: src/core/QueryManager.ts:71:11 - error TS2353: Object literal may only specify known properties, and 'projectId' does not exist in type 'ConnectorConfig'.
71 projectId: queryRef.dataConnect.app.options.projectId!,
~~~~~~~~~
src/api/Reference.ts:51:3
51 connectorConfig: ConnectorConfig;
~~~~~~~~~~~~~~~
The expected type comes from property 'connectorConfig' which is declared here on type 'RefInfo<Variables>'
yuchenshi
approved these changes
Nov 11, 2025
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Rubberstamp for API doc changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes