From 116662e53e01742b6c5d0d20c894d50f6e8b9163 Mon Sep 17 00:00:00 2001 From: Sam Stern Date: Thu, 10 Oct 2019 10:53:19 -0700 Subject: [PATCH 1/2] Use different method for setting Firepit title (#1712) --- CHANGELOG.md | 1 + standalone/firepit.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf90450c21d..10af7795b0e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,2 +1,3 @@ * Added support for managing the Realtime Database setting `strictTriggerValidation`. * Fixes trigger parser to not rely on prototype methods (#1687). +* Fixes bug where standalone CLI would hang in the Android Studio integrated terminal. \ No newline at end of file diff --git a/standalone/firepit.js b/standalone/firepit.js index 6b4c45eff01..ea07728faee 100644 --- a/standalone/firepit.js +++ b/standalone/firepit.js @@ -978,7 +978,7 @@ function SetWindowTitle(title) { if (isWindows) { process.title = title; } else { - process.stdout.write("\x1b]2;" + title + "\x1b\x5c"); + process.stdout.write(String.fromCharCode(27) + "]0;" + title + String.fromCharCode(7)); } } From a4d588dea87cdb28af9faf8fb1235d303291019e Mon Sep 17 00:00:00 2001 From: Sam Stern Date: Thu, 10 Oct 2019 11:28:06 -0700 Subject: [PATCH 2/2] Clarify warning for unknown network requests (#1711) --- src/emulator/functionsEmulator.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/emulator/functionsEmulator.ts b/src/emulator/functionsEmulator.ts index a9f16f3c66d..5f8ac895984 100644 --- a/src/emulator/functionsEmulator.ts +++ b/src/emulator/functionsEmulator.ts @@ -307,7 +307,9 @@ export class FunctionsEmulator implements EmulatorInstance { case "unidentified-network-access": EmulatorLogger.log( "WARN", - `Unknown network resource requested!\n - URL: "${systemLog.data.href}"` + `External network resource requested!\n - URL: "${ + systemLog.data.href + }"\n - Be careful, this may be a production service.` ); break; case "functions-config-missing-value":