Skip to content

Update to Cloud Firestore Emulator v1.4.4 #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanpbrewster merged 5 commits into from
Apr 9, 2019
Merged

Update to Cloud Firestore Emulator v1.4.4 #1186

ryanpbrewster merged 5 commits into from
Apr 9, 2019

Conversation

@ryanpbrewster
Copy link
Contributor

@ryanpbrewster ryanpbrewster commented Apr 8, 2019

No description provided.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Apr 8, 2019
@coveralls
Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 60.188% when pulling 1b0ab52 on rpb/firestore-1.4.4 into ec17d5e on master.

@coveralls
Copy link

coveralls commented Apr 8, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 60.188% when pulling 4902196 on rpb/firestore-1.4.4 into 52242d4 on master.

@ryanpbrewster ryanpbrewster requested a review from bkendall April 9, 2019 18:40
ryanpbrewster
ryanpbrewster commented Apr 9, 2019
View reviewed changes
changelog.txt Outdated
@@ -1,0 +1,2 @@
fixed - fixes bug in Cloud Firestore emulator where rulesets with no-op writes would modify a document's updated_at timestamp
changed - reduced lock contention in Cloud Firestore emulator during concurrent writes to a document
Copy link
Contributor Author

@ryanpbrewster ryanpbrewster Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in practice this completely eliminates the issues reported in firebase/quickstart-nodejs#64

bkendall
bkendall approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkendall @ryanpbrewster
Update changelog.txt
7ca4767 
Co-Authored-By: ryanpbrewster <RyanPBrewster@gmail.com>
@googlebot googlebot added cla: no and removed cla: yes Manual indication that this has passed CLA. labels Apr 9, 2019
@bkendall @ryanpbrewster
Update changelog.txt
4902196 
Co-Authored-By: ryanpbrewster <RyanPBrewster@gmail.com>
@ryanpbrewster ryanpbrewster added cla: yes Manual indication that this has passed CLA. and removed cla: no labels Apr 9, 2019
@googlebot
Copy link

googlebot commented Apr 9, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@firebase firebase deleted a comment from googlebot Apr 9, 2019
@firebase firebase deleted a comment from googlebot Apr 9, 2019
@ryanpbrewster ryanpbrewster merged commit b9accc3 into master Apr 9, 2019
@ryanpbrewster ryanpbrewster deleted the rpb/firestore-1.4.4 branch April 9, 2019 22:52
@Whitedragon2772 Whitedragon2772 mentioned this pull request Mar 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkendall bkendall bkendall approved these changes

Assignees

@bkendall bkendall

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryanpbrewster @coveralls @googlebot @bkendall