Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-escape new line characters from --releaseNotes arg #1739

Merged
merged 2 commits into from Oct 23, 2019

Conversation

@tonybaroneee
Copy link
Contributor

tonybaroneee commented Oct 21, 2019

Description

This allows support for using \n as a new line character in the --releaseNotes option of the appdistribution:distribute command.

Tested locally by uploading a real distribution and verifying that the release notes were correct in our backend:

Command: firebase /path/to/my.apk --app <app_id> --release-notes "New\nline"

Before: New\\nline
After: New\nline

@googlebot googlebot added the cla: yes label Oct 21, 2019
@tonybaroneee tonybaroneee requested review from mbleigh, bkendall and samtstern and removed request for mbleigh and bkendall Oct 21, 2019
@tonybaroneee tonybaroneee force-pushed the fad-release-notes-new-lines branch from 3466d9c to 01d1e86 Oct 21, 2019
@tonybaroneee tonybaroneee requested a review from rebehe Oct 21, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage increased (+0.04%) to 65.214% when pulling f327965 on fad-release-notes-new-lines into ff24cf5 on master.

@rebehe
rebehe approved these changes Oct 21, 2019
@tonybaroneee tonybaroneee requested a review from bkendall Oct 21, 2019
Copy link
Contributor

bkendall left a comment

Seems important enough to add an entry to CHANGELOG.md 🙂

This allows support for new lines characters using the `--releaseNotes` option of the appdistribution:distribute command.
@tonybaroneee tonybaroneee force-pushed the fad-release-notes-new-lines branch from 01d1e86 to 7d41d00 Oct 21, 2019
@tonybaroneee tonybaroneee requested a review from bkendall Oct 21, 2019
@tonybaroneee

This comment has been minimized.

Copy link
Contributor Author

tonybaroneee commented Oct 22, 2019

@bkendall added!

@tonybaroneee tonybaroneee requested review from bkendall and removed request for bkendall Oct 22, 2019
@tonybaroneee tonybaroneee merged commit c9019ff into master Oct 23, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tonybaroneee tonybaroneee deleted the fad-release-notes-new-lines branch Oct 23, 2019
Elgarni added a commit to Elgarni/firebase-tools that referenced this pull request Oct 26, 2019
* master:
  Un-escape new line characters from --releaseNotes arg (firebase#1739)
  update firebase-admin dev dependency (firebase#1741)
  Reject rounds=0 for SHA1 hashes (firebase#1701)
  [firebase-release] Removed change log and reset repo after 7.6.1 release
  7.6.1
  Add Firepit to cloudbuild.yaml (firebase#1637)
  lint rules cleanup x4 (firebase#1721)
  Update template dependencies (firebase#1726)
  Send correct update mask during ext:update (firebase#1724)
  add new ts rules to eslintrc (firebase#1727)
  [firebase-release] Removed change log and reset repo after 7.6.0 release
  7.6.0
  add dev tsconfig for scripts directory (firebase#1720)
  Warn when WSL users don't have Java (firebase#1717)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.