Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset global functions deploy variables on each deploy #2668

Merged
merged 1 commit into from Oct 7, 2020
Merged

Reset global functions deploy variables on each deploy #2668

merged 1 commit into from Oct 7, 2020

Conversation

kmcnellis
Copy link
Member

Description

Fix #2628

Scenarios Tested

See bug MCVE

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Oct 2, 2020
joehan
joehan approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and yikes, I hate that we are using global variables for this.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes Manual indication that this has passed CLA. labels Oct 7, 2020
@google-cla google-cla bot added cla: yes Manual indication that this has passed CLA. and removed cla: no labels Oct 7, 2020
@kmcnellis
Copy link
Member Author

(manually squashed to remove Bryan's co-authored suggestion commit, since it used a personal email that hadn't signed the cla)

@kmcnellis kmcnellis merged commit ca19cfd into firebase:master Oct 7, 2020
@kmcnellis kmcnellis deleted the duplicate-deploy branch October 7, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying Cloud Functions via firebase-tools js module results in redeploying of previous functions in memory
3 participants
@kmcnellis @bkendall @joehan