Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use of normalizedHostingConfigs when it is called repeatedly #2748

merged 2 commits into from Oct 27, 2020


Copy link


Fixes #2746

The hosting:channel:deploy path normalizes the configs once before going through the normal deploy path. Unfortunately, the normalizing process modified the underlying config which ended up causing issues when the normalize method was called a second time. Deep cloning the config fixes this issue.

Also, added some functional tests for deploying to a target and deploying to a channel!

@bkendall bkendall requested a review from mbleigh Oct 27, 2020
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Oct 27, 2020
@bkendall bkendall marked this pull request as ready for review Oct 27, 2020
@bkendall bkendall requested a review from samtstern Oct 27, 2020
@@ -42,7 +42,7 @@ EOM
mkdir "public"
touch "public/${TARGET_FILE}"
echo "${DATE}" > "public/${TARGET_FILE}"
echo "Initalized temp directory."
echo "Initialized temp directory."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initalize me cap'n!

@bkendall bkendall merged commit 4fe7bcd into master Oct 27, 2020
1 check passed
@bkendall bkendall deleted the b2746 branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes Manual indication that this has passed CLA.
None yet

Successfully merging this pull request may close these issues.

hosting:channel:deploy: Hosting configs should only include either "site" or \"target\", not both.
2 participants