Adding support for ${param:FOO} syntax #2810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaliang
approved these changes
Nov 11, 2020
Contributor
|
(drive-by merging; fixed your changelog at the same time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the extension emulator did not support ${param:FOO} syntax. Should unblock firebase/extensions#482 and fix #2777
I also did some deduping here - there were 2 substituteParams functions in different files, so I removed one and migrated the usage.
Scenarios Tested
I tested this by running both
ext:dev:emulatorscommands on an extension that used a mix of ${FOO} and ${param:FOO} syntax in its triggers. Both syntaxes worked correctly.