Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal europe-west1 region for RTDB #2812

Merged
merged 16 commits into from Nov 11, 2020
Merged

Conversation

sarajmunjal
Copy link
Contributor

Remove the rtdbmanagement flag from most commands (effectively setting it to true), except for database:instances:list where it guards a breaking change.

Scenarios Tested

firebase database:instances:create --location europe-west1 my-belgium-rtdb
firebase database:instances:list
FIREBASE_CLI_PREVIEWS=rtdbmanagement database:instances:list
firebase database:get|push|set|remove|profile
firebase settings:get|set
firebase deploy --only database

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 11, 2020
CHANGELOG.md Outdated
@@ -1 +1,3 @@
- Reveals `europe-west1` region for RTDB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Reveals `europe-west1` region for RTDB
- Adds support for the `europe-west1` region for Firebase Realtime Database.

CHANGELOG.md Outdated
- Fixes an issue where the `${param:FOO}` syntax for Firebase Extensions did not work with the emulator.
- Fixes issue in `database:settings:get` where the value wasn't being properly displayed.
- Fixes RTDB console URLs for `database:push|set|update` commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixes RTDB console URLs for `database:push|set|update` commands
- Fixes Firebase Console URLs for Firebase Realtime Database `database:push`, `database:set`, and `database:update` commands.

@sarajmunjal sarajmunjal merged commit dde1dbe into master Nov 11, 2020
1 check passed
@sarajmunjal sarajmunjal deleted the saraj/remove-rtdb-flag branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants