Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress settings support in firebase functions #2924


Copy link


Supports firebase-functions SDK in firebase/firebase-functions#815 and firebase/firebase-functions#827

    ingressSettings: "ONLY_INTERNAL_ONLY",
  .https.onRequest(() => {

Scenarios Tested

I've created a new cloud function with specific ingressSettings and it works! and, I updated its function and it also works!

Sample Commands

No change in cli.

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 12, 2020
Copy link

@takaaa220 thanks for this contribution! Hopefully @joehan can take a look at firebase/firebase-functions#827 first and then review this one.

Copy link
Contributor Author

takaaa220 commented Dec 24, 2020

Thank your for reviewing. I will resolve conflicts this week 🙇

Copy link

coveralls commented Jan 12, 2021

Coverage Status

Coverage decreased (-0.02%) to 65.558% when pulling 93f986b on takaaa220:add-ingress-settings-support-in-firebase-functions into 67cff84 on firebase:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes Manual indication that this has passed CLA.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants