Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4GB as a valid memory option for the functions emulator #3026

merged 7 commits into from Jan 15, 2021


Copy link

@joehan joehan commented Jan 12, 2021


Adds 4GB as a valid memory option for the Functions Emulator, to match firebase/firebase-functions#842.

Scenarios Tested

Tested emulating a function with availableMemoryMb="4GB".

@joehan joehan requested a review from samtstern January 12, 2021 22:28
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jan 12, 2021
Copy link

coveralls commented Jan 12, 2021

Coverage Status

Coverage decreased (-0.01%) to 65.538% when pulling 23005ff on jh-4gb-emu into 933ef1b on master.

Copy link

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry, please

@joehan joehan merged commit 0ee1329 into master Jan 15, 2021
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes Manual indication that this has passed CLA.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants