Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auth emulator export only exporting 20 users. #3311

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Apr 26, 2021

Description

Fixes b/186445689.

Scenarios Tested

Not tested 馃檭

Sample Commands

firebase emulators:export

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Apr 26, 2021
@yuchenshi yuchenshi requested a review from ssbushi April 26, 2021 20:42
Copy link
Contributor

@ssbushi ssbushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change the wording from limit to maxResults in src/emulator/auth/operations.ts (Line 451)

@yuchenshi yuchenshi merged commit b818b51 into master Apr 27, 2021
@yuchenshi yuchenshi deleted the ys/b/186445689 branch April 27, 2021 00:14
yuchenshi added a commit that referenced this pull request Apr 27, 2021
* Update CHANGELOG.md

* Update CHANGELOG.md
inlined pushed a commit that referenced this pull request Apr 27, 2021
* Fix Auth emulator export only exporting 20 users.

Fixes b/186445689

* Rename the variable limit to maxResults.
inlined pushed a commit that referenced this pull request Apr 27, 2021
* Update CHANGELOG.md

* Update CHANGELOG.md
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Fix Auth emulator export only exporting 20 users.

Fixes b/186445689

* Rename the variable limit to maxResults.
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants