Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics fix cache directory on Windows #3842

Merged
merged 3 commits into from Oct 18, 2021
Merged

Conversation

samedson
Copy link
Contributor

Description

Windows is more restrictive in terms of what characters are allowed in directories: source. Google App IDs have ":" in them which causes errors.

Scenarios Tested

EAP customer running on Windows.

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Oct 18, 2021
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md

@samedson samedson merged commit a45a8fc into master Oct 18, 2021
22 checks passed
@samedson samedson deleted the crashlytics-fix-windows branch October 18, 2021 19:29
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants