Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding to AR package names #3918

Merged
merged 4 commits into from Nov 29, 2021
Merged

Add encoding to AR package names #3918

merged 4 commits into from Nov 29, 2021

Conversation

inlined
Copy link
Member

@inlined inlined commented Nov 22, 2021

Port an internal bugfix to our CLI. GCFv1 allows upper-case names, which is a not valid for Artifact Registry. We instead encode names such that there are no upper-case letters. We can also not start or end a string with dash or underscore. We don't need to handle function IDs with leading or trailing dashes or underscores because those are invalid function IDs, but we have to special-case the encoding to prevent this situation.

@inlined inlined requested a review from taeold November 22, 2021 16:51
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 22, 2021
taeold
taeold approved these changes Nov 22, 2021
@inlined inlined merged commit 418f11c into master Nov 29, 2021
22 checks passed
@inlined inlined deleted the inlined.ar-name-mangling branch November 29, 2021 21:19
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Add encoding to AR package names

* Run formatter

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants