Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory options for some functions #3924

Merged
merged 3 commits into from Nov 30, 2021
Merged

Conversation

inlined
Copy link
Member

@inlined inlined commented Nov 30, 2021

For context, see alpha tester report

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 30, 2021
taeold
taeold approved these changes Nov 30, 2021
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, lgtm.

@@ -163,6 +163,40 @@ interface GenerateUploadUrlResponse {
storageSource: StorageSource;
}

// AvailableMemory suffixes and their byte count.
type MemoryUnit = "" | "k" | "M" | "G" | "Mi" | "Gi";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we skipping Ki b/c we don't think it's a popular choice? It looks like Cloud Run supports several more units, and our code will fail if the customer decides to use a unit not in this list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the GCF proto, it looks like Ki is not a supported unit at this time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can just extend this to support more than GCF supports pretty easily.

Copy link
Contributor

@colerogers colerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inlined inlined merged commit d1d58ec into master Nov 30, 2021
22 checks passed
@inlined inlined deleted the inlined.available-memory branch December 9, 2021 05:28
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
* Fix memory options for some functions

* Add additional units for futureproofing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants