Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in SAMLResponse nameId for pre-populated users #3946

Merged
merged 3 commits into from Dec 15, 2021
Merged

Conversation

lisajian
Copy link
Contributor

Description

A bit of cleanup from #3927. Widget should fill in the SAMLResponse correctly even for users that were signed in previously.

Corresponding internal bug: b/192387796

Scenarios Tested

Manually tested against the JSSDK Auth Demo page. See instructions here

Sample Commands

N/A

src/emulator/auth/handlers.ts Show resolved Hide resolved
src/emulator/auth/widget_ui.ts Outdated Show resolved Hide resolved
@lisajian lisajian merged commit a65e5f0 into master Dec 15, 2021
22 checks passed
@lisajian lisajian deleted the lj-handler branch December 15, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants