Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region warning for emulated database functions #5143

merged 4 commits into from Dec 2, 2022


Copy link

@colerogers colerogers commented Oct 18, 2022

  • Add warning if the function region does not match a database region. Right now, databases are only in us-central1, so any function not in that region should show this warning for better devx.

@colerogers colerogers changed the title Add warning for emulated database functions Add region warning for emulated database functions Nov 21, 2022
@colerogers colerogers marked this pull request as ready for review November 21, 2022 21:35
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Base: 56.27% // Head: 56.26% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e495bd6) compared to base (e984a6c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5143      +/-   ##
- Coverage   56.27%   56.26%   -0.01%     
  Files         309      309              
  Lines       20820    20822       +2     
  Branches     4224     4225       +1     
  Hits        11716    11716              
- Misses       8092     8094       +2     
  Partials     1012     1012              
Impacted Files Coverage Δ
src/emulator/functionsEmulator.ts 7.06% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's a changelog entry. Seems like this might surprise/break some user.

@colerogers colerogers enabled auto-merge (squash) November 22, 2022 19:03
@colerogers colerogers merged commit e1872a4 into master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants