Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experiments that should have gone out with the 4.0 functions sdk #5192

merged 3 commits into from Oct 31, 2022


Copy link

@inlined inlined commented Oct 31, 2022

Fixes #5186

the experiments functionsparams and skipdeployingnoopfunctions should have been enabled with the Firebase Summit release of the CLI.

@inlined inlined enabled auto-merge (squash) October 31, 2022 16:57
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 56.16% // Head: 56.22% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (49b2afc) compared to base (818ea6c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5192      +/-   ##
+ Coverage   56.16%   56.22%   +0.05%     
  Files         308      308              
  Lines       20752    20752              
  Branches     4206     4206              
+ Hits        11656    11667      +11     
+ Misses       8083     8071      -12     
- Partials     1013     1014       +1     
Impacted Files Coverage Δ
src/experiments.ts 63.88% <ø> (ø)
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️
src/deploy/functions/build.ts 61.67% <0.00%> (+5.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@inlined inlined merged commit 87e8f0c into master Oct 31, 2022
@inlined inlined deleted the inlined.enable-4.0-experiments branch October 31, 2022 19:20
Copy link

Has the experiment skipdeployingnoopfunctions been diasbaled because it does not seem to work for me and i cannot find any documentation about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
4 participants