Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharp library to Next.js build #5238

merged 29 commits into from Dec 12, 2022


Copy link

@cfofiu cfofiu commented Nov 11, 2022


Checking for /app dir and nextImage to add the sharp library to the Next.js build.

Scenarios Tested

In order to add the sharp library the code is looking for two things:

  • if the new routes /app folder exists
  • if isNextImageImported is set to true in .next/export-marker.json

Sample Commands

Copy link

Codecov Report

Base: 56.21% // Head: 56.21% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (629773e) compared to base (0a7b583).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files
@@                           Coverage Diff                            @@
##           jamesdaniels_skip_middleware_matches    #5238      +/-   ##
- Coverage                                 56.21%   56.21%   -0.01%     
  Files                                       308      309       +1     
  Lines                                     20808    20819      +11     
  Branches                                   4224     4226       +2     
+ Hits                                      11697    11703       +6     
- Misses                                     8102     8107       +5     
  Partials                                   1009     1009              
Impacted Files Coverage Δ
src/frameworks/next/index.ts 12.99% <33.33%> (+0.35%) ⬆️
src/frameworks/next/utils.ts 62.50% <62.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cfofiu cfofiu marked this pull request as ready for review November 15, 2022 20:14
@jamesdaniels jamesdaniels self-requested a review November 23, 2022 20:55
@jamesdaniels jamesdaniels self-assigned this Nov 23, 2022
Copy link

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog entry

src/frameworks/next/utils.ts Outdated Show resolved Hide resolved
src/frameworks/next/utils.ts Outdated Show resolved Hide resolved
src/frameworks/next/utils.ts Outdated Show resolved Hide resolved
@jamesdaniels jamesdaniels changed the base branch from jamesdaniels_skip_middleware_matches to master December 12, 2022 18:47
@jamesdaniels jamesdaniels mentioned this pull request Dec 12, 2022
@jamesdaniels jamesdaniels enabled auto-merge (squash) December 12, 2022 20:34
@jamesdaniels jamesdaniels merged commit 270f419 into firebase:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants