Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where environment variables for an emulated function did not consider emulators running remotely. #5269

merged 8 commits into from Dec 15, 2022


Copy link

@taeold taeold commented Nov 25, 2022

#5079 refactored the way to set environment variables on Functions Emulator. As implemented, the refactored function does not consider "remote" emulators i.e. emulator started by another instance of emulators:start command. This broke users who relies this to connect functions:shell command to the remote emulators.

Fixes #5225

Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 56.27% // Head: 56.25% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4aaf45b) compared to base (e984a6c).
Patch coverage: 10.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5269      +/-   ##
- Coverage   56.27%   56.25%   -0.02%     
  Files         309      309              
  Lines       20820    20825       +5     
  Branches     4224     4219       -5     
  Hits        11716    11716              
- Misses       8092     8097       +5     
  Partials     1012     1012              
Impacted Files Coverage Δ
src/emulator/commandUtils.ts 27.87% <0.00%> (-0.13%) ⬇️
src/emulator/functionsEmulator.ts 7.05% <0.00%> (-0.04%) ⬇️
src/emulator/env.ts 16.66% <13.04%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taeold taeold marked this pull request as ready for review December 13, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Firebase functions:shell is ignoring emulator and using production instead
5 participants