Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deploying Next.js utilize esbuild via NPX #5336

merged 12 commits into from Dec 15, 2022


Copy link

@jamesdaniels jamesdaniels commented Dec 14, 2022

Switch firebase deploy Next.js to shell out to npx esbuild rather than having esbuild as a (pinned) dependency in firebase-tools. Fixes #5268

src/frameworks/index.ts Outdated Show resolved Hide resolved
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 56.40% // Head: 56.42% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (57f8a1a) compared to base (0c3a688).
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5336      +/-   ##
+ Coverage   56.40%   56.42%   +0.02%     
  Files         315      315              
  Lines       21142    21145       +3     
  Branches     4285     4286       +1     
+ Hits        11926    11932       +6     
+ Misses       8191     8188       -3     
  Partials     1025     1025              
Impacted Files Coverage Δ
src/frameworks/next/index.ts 14.50% <0.00%> (-0.37%) ⬇️
src/frameworks/next/utils.ts 96.22% <100.00%> (+0.39%) ⬆️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesdaniels jamesdaniels marked this pull request as ready for review December 14, 2022 22:32
@jamesdaniels jamesdaniels changed the title Npx esbuild When deploying Next.js utilize esbuild via NPX Dec 14, 2022
Copy link

@TheIronDev TheIronDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I don't have an M1 mac to test this :(

Copy link

I successfully deployed a Next.js app with middleware in a M1 Pro using this PR's build

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 15, 2022 22:33
@jamesdaniels jamesdaniels merged commit d073b09 into master Dec 15, 2022
@jamesdaniels jamesdaniels deleted the npx_esbuild branch December 15, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

firebase deploy --only hosting fails with webframeworks experiment enabled
4 participants