Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using v2 functions enable Compute Service API and grant its P4SA necessary IAM roles #5338

merged 5 commits into from Dec 14, 2022


Copy link

@pavelgj pavelgj commented Dec 14, 2022

No description provided.

@pavelgj pavelgj requested a review from joehan December 14, 2022 19:45
Copy link

Codecov Report

Base: 56.38% // Head: 56.42% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (72e0377) compared to base (3d89222).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5338      +/-   ##
+ Coverage   56.38%   56.42%   +0.04%     
  Files         314      315       +1     
  Lines       21102    21138      +36     
  Branches     4286     4290       +4     
+ Hits        11899    11928      +29     
- Misses       8178     8185       +7     
  Partials     1025     1025              
Impacted Files Coverage Δ
src/deploy/extensions/prepare.ts 23.07% <25.00%> (+0.10%) ⬆️
src/deploy/extensions/v2FunctionHelper.ts 81.25% <81.25%> (ø)
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but lgtm

src/deploy/extensions/v2FunctionHelper.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj merged commit 2a25c5f into master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants