New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding `firebase login:ci` command #71

Merged
merged 21 commits into from Oct 16, 2015

Conversation

Projects
None yet
4 participants
@drtriumph
Member

drtriumph commented Oct 14, 2015

Replacing #70 with this against the next branch to stage changes

jwngr and others added some commits Oct 13, 2015

Adding `firebase login:ci` command that always re-authenticates and c…
…reates a new session token without persisting it
@@ -22,63 +16,20 @@ module.exports = new Command('login')
return utils.reject('Cannot run login in non-interactive mode. Pass ' + chalk.bold('--token') + ' instead.', {exit: 1});

This comment has been minimized.

@mbleigh

mbleigh Oct 14, 2015

Contributor

I think we need to update this message, maybe:

Cannot run login in non-interactive mode. See login:ci to generate a token for use in non-interactive environments.

Don't love that wording, but think the current is a bit confusing.

}
return login().then(function(auth) {
utils.logSuccess('Success! Use this token to login on a CI server: "' + chalk.bold(auth.session.token) + '"');

This comment has been minimized.

@mbleigh

mbleigh Oct 14, 2015

Contributor

Let's print the token after \n\n so that it's very clear and easy to copy.

.description('sign into Firebase ')
.action(function(options) {
if (utils.getInheritedOption(options, 'nonInteractive')) {
return utils.reject('Cannot run login in non-interactive mode. Pass ' + chalk.bold('--token') + ' instead.', {exit: 1});

This comment has been minimized.

@mbleigh

mbleigh Oct 14, 2015

Contributor

Again I think this needs a reword, but I'm struggling to find something that sounds right. Any ideas?

@mbleigh mbleigh assigned drtriumph and unassigned mbleigh Oct 14, 2015

@mbleigh

This comment has been minimized.

Contributor

mbleigh commented Oct 14, 2015

Great implementation! Just a few thoughts on error message and success wording.

jwngr and others added some commits Oct 14, 2015

Merge pull request #67 from firebase/jw-public-arg-for-deploy
Added -p / --public arg back to firebase deploy
Merge pull request #74 from firebase/jw-engine-strict
Updated deprecated fields in package.json
Jacob Wenger
Merge pull request #72 from firebase/mb-headless-progress
Don't use ProgressBar when non-interactive.
Merge pull request #75 from firebase/jw-2-0-1-changelog
Added change log for upcoming 2.0.1 release
@googlebot

This comment has been minimized.

googlebot commented Oct 16, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@drtriumph

This comment has been minimized.

Member

drtriumph commented Oct 16, 2015

Confirm

@mbleigh

This comment has been minimized.

Contributor

mbleigh commented Oct 16, 2015

LGTM!

mbleigh added a commit that referenced this pull request Oct 16, 2015

Merge pull request #71 from firebase/cr-ci-login
Adding `firebase login:ci` command

@mbleigh mbleigh merged commit 11772c6 into next Oct 16, 2015

2 of 3 checks passed

cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mbleigh mbleigh deleted the cr-ci-login branch Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment