From 2031c0b425d49f29fbb707b38ab1044993573f8e Mon Sep 17 00:00:00 2001 From: Joanna Wang Date: Tue, 23 Sep 2025 03:00:47 +0000 Subject: [PATCH 1/2] Fix never-ending rollout.spect.ts test --- src/deploy/apphosting/release.spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/deploy/apphosting/release.spec.ts b/src/deploy/apphosting/release.spec.ts index e34e3b78a26..f2b604de3f1 100644 --- a/src/deploy/apphosting/release.spec.ts +++ b/src/deploy/apphosting/release.spec.ts @@ -66,7 +66,9 @@ describe("apphosting", () => { }, }, }; - + // Promise.allSettled is not resolving as expected with stubed tests. + // We stub allSettled here as a hack. + sinon.stub(Promise, "allSettled").resolves([]); orchestrateRolloutStub = sinon.stub(rollout, "orchestrateRollout").resolves({ rollout: { name: "rollout-name", From 2e49d43d4d101769d2926c6fe28e00a583f5edda Mon Sep 17 00:00:00 2001 From: Joanna Wang Date: Tue, 23 Sep 2025 03:08:31 +0000 Subject: [PATCH 2/2] wording --- src/deploy/apphosting/release.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/deploy/apphosting/release.spec.ts b/src/deploy/apphosting/release.spec.ts index f2b604de3f1..1677f088e65 100644 --- a/src/deploy/apphosting/release.spec.ts +++ b/src/deploy/apphosting/release.spec.ts @@ -66,7 +66,7 @@ describe("apphosting", () => { }, }, }; - // Promise.allSettled is not resolving as expected with stubed tests. + // Promise.allSettled is not resolving as expected with stubbed Promise. // We stub allSettled here as a hack. sinon.stub(Promise, "allSettled").resolves([]); orchestrateRolloutStub = sinon.stub(rollout, "orchestrateRollout").resolves({