fix: Force upload for non-ACTIVE functions to prevent GCFv2 update failure

[taeold]

When a GCFv2 function is in a FAILED state but the local source code hasn't changed, the CLI previously skipped the source upload. This caused the subsequent update operation to fail with 'Precondition failed' because it lacked the required storage source information.

This change ensures that source upload is only skipped if the existing function is in an ACTIVE state, forcing a re-upload and allowing repair of FAILED functions.

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the deployment process for Google Cloud Functions v2. Previously, the CLI would erroneously skip source code uploads for functions that were in a 'FAILED' state but had unchanged local source code, resulting in "Precondition failed" errors during subsequent update attempts. The implemented changes enhance the 'shouldUploadBeSkipped' logic to explicitly check if a function is in an 'ACTIVE' state before allowing a source upload to be skipped, thereby guaranteeing that functions requiring repair or update, especially those in a 'FAILED' state, always receive a fresh source upload.

Highlights

• Deployment Logic Fix: Corrected an issue where the CLI would skip source uploads for GCFv2 functions in a 'FAILED' state, leading to update failures due to missing storage source information.
• State-Aware Uploads: Modified the 'shouldUploadBeSkipped' function to only skip source uploads if the existing function is in an 'ACTIVE' state and its source hash matches the desired state.
• Improved Reliability: Ensures that functions in non-'ACTIVE' states (e.g., 'FAILED') are always re-uploaded, allowing for successful repairs and updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where updating a GCFv2 function in a FAILED state would fail due to a skipped source upload. The change in shouldUploadBeSkipped to only skip uploads for functions in an ACTIVE state is a good fix. The new tests verify this behavior effectively. I've left one comment regarding a redundant test case to improve the maintainability of the test suite.

[taeold]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively resolves the 'Precondition failed' error encountered when updating GCFv2 functions that are in a FAILED state without local code changes. The core change in shouldUploadBeSkipped correctly ensures that source code is re-uploaded for non-ACTIVE functions, providing the necessary storage source information. The added test cases in deploy.spec.ts adequately cover this new logic, ensuring the fix behaves as expected. The changelog entry clearly documents the resolution.