From de78d60aec291f2792fd2e71030afd6906eb1771 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Thu, 5 Jan 2023 10:56:54 -0500 Subject: [PATCH 1/2] disable failing Dynamic Links tests on mobile --- .../Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs b/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs index ea5f1f06..35fd29af 100644 --- a/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs +++ b/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs @@ -32,7 +32,8 @@ public class UIHandlerAutomated : UIHandler { public override void Start() { Func[] tests = { TestCreateLongLinkAsync, -#if (UNITY_ANDROID || UNITY_IOS) +// TODO(b/264533368) Enable theses tests when the issue has been fixed. +#if 0 // (UNITY_ANDROID || UNITY_IOS) // Link shortening does not work on desktop builds, so only test that for mobile. TestCreateShortLinkAsync, TestCreateUnguessableShortLinkAsync, From 2b9346863d99be22cc7a5a1ac1727c73fe1b44d8 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Thu, 5 Jan 2023 17:23:43 -0500 Subject: [PATCH 2/2] change preprocessor definition --- .../Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs b/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs index 35fd29af..7a1286e8 100644 --- a/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs +++ b/dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs @@ -33,7 +33,7 @@ public override void Start() { Func[] tests = { TestCreateLongLinkAsync, // TODO(b/264533368) Enable theses tests when the issue has been fixed. -#if 0 // (UNITY_ANDROID || UNITY_IOS) +#if (false) // (UNITY_ANDROID || UNITY_IOS) // Link shortening does not work on desktop builds, so only test that for mobile. TestCreateShortLinkAsync, TestCreateUnguessableShortLinkAsync,