Fix build_testapp scripts for desktop targets #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlmostMatt
approved these changes
Jan 19, 2023
Contributor
AlmostMatt
left a comment
AlmostMatt
left a comment
There was a problem hiding this comment.
Changing desktop to list out the desktop platforms seems good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I introduced a bug in our build system with PR #599 where I added an explicit list of build targets for each SDK's testapp. In this change I errantly listed "Desktop" as a possible target, but really desktop is either "Windows, "Linux", or "macOS".
This PR fixes the issue by expanding Desktop entries to those values.
Testing
Integration Test CI
Type of Change
Place an
xthe applicable box: