Skip to content

Uninstall platforms;android-33-ext4 when building testapps #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

Uninstall platforms;android-33-ext4 when building testapps #604

merged 2 commits into from
Jan 19, 2023

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Jan 19, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.
Uninstalls both platforms;android-33 and platforms;android-33-ext4 instead of just platforms;android-33

Without this change build_testapps was failing the minify with proguard step for build-2020-windows-latest-Android-NA: example

Testing

Describe how you've tested these changes.

Ran the build_testapps workflow without and with this change.
Added list_installed to the script so that the installed platforms is logged and verified that android-33-ext4 was still installed even after uninstalling android-33

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2023
@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

⏳  Integration test in progress...

Requested by @AlmostMatt on commit refs/pull/604/merge
Last updated: Thu Jan 19 12:01 PST 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2023
@AlmostMatt AlmostMatt changed the title Debug the uninstallation of android 33 - android windows testapp build failure Properly uninstall unsupported android API when building testapps Jan 19, 2023
@AlmostMatt AlmostMatt changed the title Properly uninstall unsupported android API when building testapps Uninstall platforms;android-33-extr4 when building testapps Jan 19, 2023
@AlmostMatt AlmostMatt requested a review from a-maurice January 19, 2023 20:00
@AlmostMatt AlmostMatt changed the title Uninstall platforms;android-33-extr4 when building testapps Uninstall platforms;android-33-ext4 when building testapps Jan 19, 2023
@AlmostMatt AlmostMatt marked this pull request as ready for review January 19, 2023 20:01
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 19, 2023
@AlmostMatt AlmostMatt merged commit b5ec18a into main Jan 19, 2023
@AlmostMatt AlmostMatt deleted the amatt-windows-android-build branch January 19, 2023 21:28
@firebase firebase locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

No one assigned

Labels

tests: in-progress This PR's integration tests are in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlmostMatt @a-maurice