From 3b1807fb249b1b230f40b080cccf3fb0ec38e01b Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Thu, 17 Oct 2024 14:41:45 +0000 Subject: [PATCH 1/2] fix(remote_config): ensure all listeners fire on onConfigUpdated --- .../method_channel_firebase_remote_config.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart b/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart index f916e466fc49..35cde14387b5 100644 --- a/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart +++ b/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart @@ -293,13 +293,17 @@ class MethodChannelFirebaseRemoteConfig extends FirebaseRemoteConfigPlatform { static const EventChannel _eventChannelConfigUpdated = EventChannel('plugins.flutter.io/firebase_remote_config_updated'); + Stream? _onConfigUpdatedStream; + @override Stream get onConfigUpdated { - return _eventChannelConfigUpdated.receiveBroadcastStream({ + _onConfigUpdatedStream ??= + _eventChannelConfigUpdated.receiveBroadcastStream({ 'appName': app.name, }).map((event) { final updatedKeys = Set.from(event); return RemoteConfigUpdate(updatedKeys); }); + return _onConfigUpdatedStream!; } } From a8b4ced52f63051241e3600c148de177071b548e Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Fri, 18 Oct 2024 09:22:46 +0000 Subject: [PATCH 2/2] chore: run format --- .../method_channel/method_channel_firebase_remote_config.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart b/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart index 35cde14387b5..4cc08ba89d74 100644 --- a/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart +++ b/packages/firebase_remote_config/firebase_remote_config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart @@ -294,7 +294,7 @@ class MethodChannelFirebaseRemoteConfig extends FirebaseRemoteConfigPlatform { EventChannel('plugins.flutter.io/firebase_remote_config_updated'); Stream? _onConfigUpdatedStream; - + @override Stream get onConfigUpdated { _onConfigUpdatedStream ??=