From bee8c56e0e25c35a447a149addcffa9997273d08 Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Mon, 27 Oct 2025 13:15:31 +0000 Subject: [PATCH 1/2] fix(installations, web): More explicit interop types --- .../lib/src/interop/installations_interop.dart | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart b/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart index 0bc32d68b4ea..f8d3880fb903 100644 --- a/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart +++ b/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart @@ -30,12 +30,15 @@ external JSPromise /* void */ deleteInstallations( @JS() @staticInterop external JSFunction onIdChange( - InstallationsJsImpl installations, JSFunction forceRefresh); + JSObject installations, JSFunction forceRefresh); -@JS('Installations') -@staticInterop -abstract class InstallationsJsImpl {} - -extension InstallationsJsImplExtension on InstallationsJsImpl { +extension type InstallationsJsImplExtension._(JSObject _) implements JSObject { external AppJsImpl get app; } + +extension type InstallationsJsImpl._(JSObject _) implements JSObject { + external JSPromise getId(); + external JSPromise getToken([JSBoolean? forceRefresh]); + external JSPromise deleteInstallations(); + external JSFunction onIdChange(JSFunction forceRefresh); +} From 42167902a2c7d5e31f7f9e4b1996826e2d8ebb7c Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Mon, 27 Oct 2025 13:24:52 +0000 Subject: [PATCH 2/2] chore: format-ci --- .../lib/src/interop/installations_interop.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart b/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart index f8d3880fb903..64a899e4e9fb 100644 --- a/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart +++ b/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations_interop.dart @@ -29,8 +29,7 @@ external JSPromise /* void */ deleteInstallations( @JS() @staticInterop -external JSFunction onIdChange( - JSObject installations, JSFunction forceRefresh); +external JSFunction onIdChange(JSObject installations, JSFunction forceRefresh); extension type InstallationsJsImplExtension._(JSObject _) implements JSObject { external AppJsImpl get app;