From 59549adc938f7e0b8ed4b57d351ebb94abf3b178 Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Thu, 6 Nov 2025 16:22:32 +0000 Subject: [PATCH] fix(firebase_remote_config, web): update getSource method call in RemoteConfig class and add test for getAll() method --- .../lib/src/interop/firebase_remote_config.dart | 2 +- .../firebase_remote_config_e2e_test.dart | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart b/packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart index 473fb662131e..045409fd398a 100644 --- a/packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart +++ b/packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart @@ -123,7 +123,7 @@ class RemoteConfig remote_config_interop.getValue(jsObject, key.toJS).asString().toDart, ), getSource( - remote_config_interop.getValue(jsObject, key.toJS).asString().toDart, + remote_config_interop.getValue(jsObject, key.toJS).getSource().toDart, ), ); diff --git a/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart b/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart index 3ffc3f0490c9..16ea32311c1f 100644 --- a/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart +++ b/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart @@ -154,6 +154,19 @@ void main() { expect(FirebaseRemoteConfig.instance.getDouble('does-not-exist'), 0.0); }); + test( + 'getAll() returns without throwing', + () async { + try { + await FirebaseRemoteConfig.instance.fetchAndActivate(); + FirebaseRemoteConfig.instance.getAll(); + } on UnimplementedError catch (e) { + fail('getAll() threw an exception: $e'); + } + }, + skip: !kIsWeb, + ); + group('setCustomSignals()', () { test('valid signal values; `string`, `number` & `null`', () async { const signals = {