Skip to content

fix(app-check): token not available on new session #17872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

fix(app-check): token not available on new session #17872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,19 @@ class FirebaseAppCheckWeb extends FirebaseAppCheckPlatform {
ensurePluginInitialized: (firebaseApp) async {
final instance =
FirebaseAppCheckWeb(app: Firebase.app(firebaseApp.name));
final recaptchaType = web.window.sessionStorage
var recaptchaType = web.window.localStorage
.getItem(_sessionKeyRecaptchaType(firebaseApp.name));
final recaptchaSiteKey = web.window.sessionStorage
var recaptchaSiteKey = web.window.localStorage
.getItem(_sessionKeyRecaptchaSiteKey(firebaseApp.name));

// For backwards compatibility, with previously used session storage
if (recaptchaType == null || recaptchaSiteKey == null) {
recaptchaType = web.window.sessionStorage
.getItem(_sessionKeyRecaptchaType(firebaseApp.name));
recaptchaSiteKey = web.window.sessionStorage
.getItem(_sessionKeyRecaptchaSiteKey(firebaseApp.name));
}

if (recaptchaType != null && recaptchaSiteKey != null) {
final WebProvider provider;
if (recaptchaType == recaptchaTypeV3) {
Expand Down Expand Up @@ -125,9 +134,9 @@ class FirebaseAppCheckWeb extends FirebaseAppCheckPlatform {
} else {
throw Exception('Invalid web provider: $webProvider');
}
web.window.sessionStorage
web.window.localStorage
.setItem(_sessionKeyRecaptchaType(app.name), recaptchaType);
web.window.sessionStorage
web.window.localStorage
.setItem(_sessionKeyRecaptchaSiteKey(app.name), webProvider.siteKey);
}

Expand Down
Loading