From ae0f65b4110fbfbe73f574e9c7a51394c7ec34bf Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Tue, 25 Nov 2025 11:24:27 +0000 Subject: [PATCH 1/2] refactor(firebase_core, web): stop passing variant to registerVersion --- .../firebase_core/firebase_core_web/lib/src/interop/core.dart | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart b/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart index d2e3ec38d540..bf6615f098a4 100644 --- a/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart +++ b/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart @@ -61,12 +61,10 @@ App app([String? name]) { ); } -void registerVersion(String libraryKeyOrName, String version, - [String? variant]) { +void registerVersion(String libraryKeyOrName, String version) { firebase_interop.registerVersion( libraryKeyOrName.toJS, version.toJS, - variant?.toJS ?? 'flutter-firebase'.toJS, ); } From 30417a554392cdc2380ae076e21045c54dd64c61 Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Tue, 25 Nov 2025 14:03:16 +0000 Subject: [PATCH 2/2] refactor(firebase_core, web): add optional variant parameter to registerVersion --- .../firebase_core/firebase_core_web/lib/src/interop/core.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart b/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart index bf6615f098a4..36f439e65689 100644 --- a/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart +++ b/packages/firebase_core/firebase_core_web/lib/src/interop/core.dart @@ -61,10 +61,12 @@ App app([String? name]) { ); } -void registerVersion(String libraryKeyOrName, String version) { +void registerVersion(String libraryKeyOrName, String version, + [String? variant]) { firebase_interop.registerVersion( libraryKeyOrName.toJS, version.toJS, + variant?.toJS, ); }