From 9e48d1cd53cbbda057479db4368da20c841404d9 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Wed, 8 Sep 2021 15:49:23 +0200 Subject: [PATCH 1/3] fix(crashlytics): fix example --- .../firebase_crashlytics/example/lib/main.dart | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart index ea14b78daecf..22d9480c9890 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart @@ -20,10 +20,10 @@ const _kShouldTestAsyncErrorOnInit = false; // Toggle this for testing Crashlytics in your app locally. const _kTestingCrashlytics = true; //ignore: avoid_void_async -void main() { - runZonedGuarded(() async { - WidgetsFlutterBinding.ensureInitialized(); - await Firebase.initializeApp(); +void main() async { + WidgetsFlutterBinding.ensureInitialized(); + await Firebase.initializeApp(); + runZonedGuarded(() { runApp(MyApp()); }, FirebaseCrashlytics.instance.recordError); } From 684d06094a908825bd10f6ea8f0c1e604551a1f1 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Thu, 9 Sep 2021 11:45:20 +0200 Subject: [PATCH 2/3] fix(crashlytics): fix example so async errors are caught --- .../firebase_crashlytics/example/lib/main.dart | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart index 22d9480c9890..3cd1535b5b3c 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart @@ -20,12 +20,14 @@ const _kShouldTestAsyncErrorOnInit = false; // Toggle this for testing Crashlytics in your app locally. const _kTestingCrashlytics = true; //ignore: avoid_void_async -void main() async { - WidgetsFlutterBinding.ensureInitialized(); - await Firebase.initializeApp(); - runZonedGuarded(() { +void main() { + runZonedGuarded(() async { + WidgetsFlutterBinding.ensureInitialized(); + await Firebase.initializeApp(); runApp(MyApp()); - }, FirebaseCrashlytics.instance.recordError); + }, (error, stackTrace) { + FirebaseCrashlytics.instance.recordError(error, stackTrace); + }); } class MyApp extends StatefulWidget { From f5f18df6b0d261288c0b54518f9f6a843cc29ac7 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Thu, 9 Sep 2021 11:58:33 +0200 Subject: [PATCH 3/3] chore(crashlytics): FlutterError.onError --- .../firebase_crashlytics/example/lib/main.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart index 3cd1535b5b3c..d63cd8297f81 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics/example/lib/main.dart @@ -24,6 +24,7 @@ void main() { runZonedGuarded(() async { WidgetsFlutterBinding.ensureInitialized(); await Firebase.initializeApp(); + FlutterError.onError = FirebaseCrashlytics.instance.recordFlutterError; runApp(MyApp()); }, (error, stackTrace) { FirebaseCrashlytics.instance.recordError(error, stackTrace);