fix(firebase_database): Fix MissingPluginException caused by malformed EventChannel name.
#7859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In retrospect, I don't think we need to track the event channel names at all. In other plugins, we keep a map of stream handlers so we can clean up. In this implementation, we pass a "dispose of" function to the event channel to clean up the stream handler. So the event names aren't used for anything.
So, I think we can remove the
queryListenersand associated code. Thoughts, @Salakar?Will roll out for iOS once I have a second opinion 😄.
Update
Every event stream has a new number id for android & iOS.
Related Issues
fixes #7795
fixes #7556
I suspect it fixes this issue as well: #7618
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?