From 13d5c44d08b96aaf152c64ad3635ec0a6d65aaf4 Mon Sep 17 00:00:00 2001 From: Dan Tavelli Date: Fri, 16 Feb 2018 21:09:58 -0500 Subject: [PATCH 1/2] remove return statement from console.log causes compilation failure when using typescript --- image-sharp/functions/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/image-sharp/functions/index.js b/image-sharp/functions/index.js index c56130001e..7a9089380e 100644 --- a/image-sharp/functions/index.js +++ b/image-sharp/functions/index.js @@ -88,6 +88,6 @@ exports.generateThumbnail = functions.storage.object().onChange((event) => { thumbnailUploadStream.on('finish', resolve).on('error', reject)); return streamAsPromise.then(() => { - return console.log('Thumbnail created successfully'); + console.log('Thumbnail created successfully'); }); }); From f754f5cef0dd6b59e063e0319680b81392db94f2 Mon Sep 17 00:00:00 2001 From: Nicolas Garnier Date: Tue, 27 Feb 2018 21:18:13 +0100 Subject: [PATCH 2/2] add return to Promise --- image-sharp/functions/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/image-sharp/functions/index.js b/image-sharp/functions/index.js index 7a9089380e..d60b5df3c2 100644 --- a/image-sharp/functions/index.js +++ b/image-sharp/functions/index.js @@ -89,5 +89,6 @@ exports.generateThumbnail = functions.storage.object().onChange((event) => { return streamAsPromise.then(() => { console.log('Thumbnail created successfully'); + return null; }); });